gpu: Disallow null client ids in Gen* functions

gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 250 matching lines @@
     GenVertexArraysOESImmediate* cmd =
         GetImmediateAs<GenVertexArraysOESImmediate>();
     GLuint temp = kNewClientId;
     cmd->Init(1, &temp);
     EXPECT_EQ(error::kNoError, ExecuteImmediateCmd(*cmd, sizeof(temp)));
     EXPECT_EQ(GL_NO_ERROR, GetGLError());
     EXPECT_TRUE(GetVertexArrayInfo(kNewClientId) != NULL);
     AddExpectationsForDeleteVertexArraysOES();
   }
 
-  void GenVertexArraysOESImmediateDuplicateIds() {
+  void GenVertexArraysOESImmediateDuplicateOrNullIds() {
     cmds::GenVertexArraysOESImmediate* cmd =
         GetImmediateAs<cmds::GenVertexArraysOESImmediate>();
     GLuint temp[3] = {kNewClientId, kNewClientId + 1, kNewClientId};
     cmd->Init(3, temp);
     EXPECT_EQ(error::kInvalidArguments,
               ExecuteImmediateCmd(*cmd, sizeof(temp)));
     EXPECT_TRUE(GetVertexArrayInfo(kNewClientId) == NULL);
     EXPECT_TRUE(GetVertexArrayInfo(kNewClientId + 1) == NULL);
+    GLuint null_id[2] = {kNewClientId, 0};
+    cmd->Init(2, null_id);
+    EXPECT_EQ(error::kInvalidArguments,
+              ExecuteImmediateCmd(*cmd, sizeof(temp)));
+    EXPECT_TRUE(GetVertexArrayInfo(kNewClientId) == NULL);
   }
 
   void GenVertexArraysOESImmediateInvalidArgs() {
     EXPECT_CALL(*gl_, GenVertexArraysOES(_, _)).Times(0);
     GenVertexArraysOESImmediate* cmd =
         GetImmediateAs<GenVertexArraysOESImmediate>();
     cmd->Init(1, &client_vertexarray_id_);
     EXPECT_EQ(error::kInvalidArguments,
               ExecuteImmediateCmd(*cmd, sizeof(&client_vertexarray_id_)));
   }
@@ skipping 95 matching lines @@
 // Test vertex array objects with native support
 TEST_P(GLES2DecoderVertexArraysOESTest, GenVertexArraysOESImmediateValidArgs) {
   GenVertexArraysOESImmediateValidArgs();
 }
 TEST_P(GLES2DecoderEmulatedVertexArraysOESTest,
        GenVertexArraysOESImmediateValidArgs) {
   GenVertexArraysOESImmediateValidArgs();
 }
 
 TEST_P(GLES2DecoderVertexArraysOESTest,
-       GenVertexArraysOESImmediateDuplicateIds) {
-  GenVertexArraysOESImmediateDuplicateIds();
+       GenVertexArraysOESImmediateDuplicateOrNullIds) {
+  GenVertexArraysOESImmediateDuplicateOrNullIds();
 }
 TEST_P(GLES2DecoderEmulatedVertexArraysOESTest,
-       GenVertexArraysOESImmediateDuplicateIds) {
-  GenVertexArraysOESImmediateDuplicateIds();
+       GenVertexArraysOESImmediateDuplicateOrNullIds) {
+  GenVertexArraysOESImmediateDuplicateOrNullIds();
 }
 
 TEST_P(GLES2DecoderVertexArraysOESTest,
        GenVertexArraysOESImmediateInvalidArgs) {
   GenVertexArraysOESImmediateInvalidArgs();
 }
 TEST_P(GLES2DecoderEmulatedVertexArraysOESTest,
        GenVertexArraysOESImmediateInvalidArgs) {
   GenVertexArraysOESImmediateInvalidArgs();
 }
@@ skipping 81 matching lines @@
 // TODO(gman): BufferData
 
 // TODO(gman): BufferDataImmediate
 
 // TODO(gman): BufferSubData
 
 // TODO(gman): BufferSubDataImmediate
 
 }  // namespace gles2
 }  // namespace gpu