Move IPC fuzzer switches and helpers from chrome/common to content/common.

Move IPC fuzzer switches and helpers from chrome/common to content/common.

BUG=607649
Committed: https://crrev.com/dd89a1e1f3f9e283d157f4edb9d419c899f36bf4
Cr-Commit-Position: refs/heads/master@{#398595}

[Oliver Chang, 2016-06-06 22:09:54]

Description was changed from

==========
Move IPC fuzzer switches and helpers from chrome/common to
content/public/common.

BUG=607649
==========

to

==========
Move IPC fuzzer switches and helpers from chrome/common to
content/public/common.

BUG=607649
==========

[Oliver Chang, 2016-06-06 22:09:54]

ochang@chromium.org changed reviewers:
+ jochen@chromium.org, mbarbella@chromium.org

[Oliver Chang, 2016-06-06 22:20:44]

ptal.

Marty, as discussed, this is necessary to hook into some mojo functionality in
content/.

[Martin Barbella, 2016-06-06 22:25:33]

lgtm

[jochen (gone - plz use gerrit), 2016-06-07 15:10:29]

https://codereview.chromium.org/2043933002/diff/20001/content/public/common/c...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/2043933002/diff/20001/content/public/common/c...
content/public/common/content_switches.h:315: CONTENT_EXPORT extern const char
kIpcDumpDirectory[];
is this used outside of content? If not, drop CONTENT_EXPORT

https://codereview.chromium.org/2043933002/diff/20001/content/public/common/e...
File content/public/common/external_ipc_dumper.h (right):

https://codereview.chromium.org/2043933002/diff/20001/content/public/common/e...
content/public/common/external_ipc_dumper.h:9: 
this should be in namespace content

This is only used from renderer, right?

[Oliver Chang, 2016-06-07 15:40:14]

Patchset #3 (id:40001) has been deleted

[Oliver Chang, 2016-06-07 15:41:17]

Thanks for reviewing, jochen.

https://codereview.chromium.org/2043933002/diff/20001/content/public/common/c...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/2043933002/diff/20001/content/public/common/c...
content/public/common/content_switches.h:315: CONTENT_EXPORT extern const char
kIpcDumpDirectory[];
On 2016/06/07 15:10:29, jochen wrote:
> is this used outside of content? If not, drop CONTENT_EXPORT

Yeah, it is used outside of content.

https://codereview.chromium.org/2043933002/diff/20001/content/public/common/e...
File content/public/common/external_ipc_dumper.h (right):

https://codereview.chromium.org/2043933002/diff/20001/content/public/common/e...
content/public/common/external_ipc_dumper.h:9: 
On 2016/06/07 15:10:29, jochen wrote:
> this should be in namespace content
> 
> This is only used from renderer, right?

Done. The browser will use this too.

This should be a CONTENT_EXPORT too, since stuff outside of content/ will use
it, right?

[jochen (gone - plz use gerrit), 2016-06-07 18:53:41]

https://codereview.chromium.org/2043933002/diff/60001/content/public/common/c...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/2043933002/diff/60001/content/public/common/c...
content/public/common/content_switches.h:317: #endif
seems like it's just used in chrome to copy the switches over. can you move this
logic to RenderProcessHostImpl::AppendRendererCommandLine ?

https://codereview.chromium.org/2043933002/diff/60001/content/public/common/e...
File content/public/common/external_ipc_dumper.h (right):

https://codereview.chromium.org/2043933002/diff/60001/content/public/common/e...
content/public/common/external_ipc_dumper.h:13: CONTENT_EXPORT
IPC::ChannelProxy::OutgoingMessageFilter* LoadExternalIPCDumper(
should be possible to move the call to this API to inside content, no?

then we wouldn't need a public API for this.

[Oliver Chang, 2016-06-07 21:09:55]

Description was changed from

==========
Move IPC fuzzer switches and helpers from chrome/common to
content/public/common.

BUG=607649
==========

to

==========
Move IPC fuzzer switches and helpers from chrome/common to content/common.

BUG=607649
==========

[Oliver Chang, 2016-06-07 21:16:47]

Patchset #4 (id:80001) has been deleted

[Oliver Chang, 2016-06-07 21:27:36]

https://codereview.chromium.org/2043933002/diff/60001/content/public/common/c...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/2043933002/diff/60001/content/public/common/c...
content/public/common/content_switches.h:317: #endif
On 2016/06/07 18:53:41, jochen wrote:
> seems like it's just used in chrome to copy the switches over. can you move
this
> logic to RenderProcessHostImpl::AppendRendererCommandLine ?

Done. But I would like to keep the CONTENT_EXPORT, as I plan to extend the IPC
fuzzer such that it may be needed outside of content/

https://codereview.chromium.org/2043933002/diff/60001/content/public/common/e...
File content/public/common/external_ipc_dumper.h (right):

https://codereview.chromium.org/2043933002/diff/60001/content/public/common/e...
content/public/common/external_ipc_dumper.h:13: CONTENT_EXPORT
IPC::ChannelProxy::OutgoingMessageFilter* LoadExternalIPCDumper(
On 2016/06/07 18:53:41, jochen wrote:
> should be possible to move the call to this API to inside content, no?
> 
> then we wouldn't need a public API for this.

Done.

[jochen (gone - plz use gerrit), 2016-06-08 14:55:22]

On 2016/06/07 at 21:27:36, ochang wrote:
>
https://codereview.chromium.org/2043933002/diff/60001/content/public/common/c...
> File content/public/common/content_switches.h (right):
> 
>
https://codereview.chromium.org/2043933002/diff/60001/content/public/common/c...
> content/public/common/content_switches.h:317: #endif
> On 2016/06/07 18:53:41, jochen wrote:
> > seems like it's just used in chrome to copy the switches over. can you move
this
> > logic to RenderProcessHostImpl::AppendRendererCommandLine ?
> 
> Done. But I would like to keep the CONTENT_EXPORT, as I plan to extend the IPC
fuzzer such that it may be needed outside of content/
> 
>
https://codereview.chromium.org/2043933002/diff/60001/content/public/common/e...
> File content/public/common/external_ipc_dumper.h (right):
> 
>
https://codereview.chromium.org/2043933002/diff/60001/content/public/common/e...
> content/public/common/external_ipc_dumper.h:13: CONTENT_EXPORT
IPC::ChannelProxy::OutgoingMessageFilter* LoadExternalIPCDumper(
> On 2016/06/07 18:53:41, jochen wrote:
> > should be possible to move the call to this API to inside content, no?
> > 
> > then we wouldn't need a public API for this.
> 
> Done.

I'd prefer to make this part of the public API at the point when we need it.

[Oliver Chang, 2016-06-08 15:19:05]

On 2016/06/08 14:55:22, jochen wrote:
> On 2016/06/07 at 21:27:36, ochang wrote:
> >
>
https://codereview.chromium.org/2043933002/diff/60001/content/public/common/c...
> > File content/public/common/content_switches.h (right):
> > 
> >
>
https://codereview.chromium.org/2043933002/diff/60001/content/public/common/c...
> > content/public/common/content_switches.h:317: #endif
> > On 2016/06/07 18:53:41, jochen wrote:
> > > seems like it's just used in chrome to copy the switches over. can you
move
> this
> > > logic to RenderProcessHostImpl::AppendRendererCommandLine ?
> > 
> > Done. But I would like to keep the CONTENT_EXPORT, as I plan to extend the
IPC
> fuzzer such that it may be needed outside of content/
> > 
> >
>
https://codereview.chromium.org/2043933002/diff/60001/content/public/common/e...
> > File content/public/common/external_ipc_dumper.h (right):
> > 
> >
>
https://codereview.chromium.org/2043933002/diff/60001/content/public/common/e...
> > content/public/common/external_ipc_dumper.h:13: CONTENT_EXPORT
> IPC::ChannelProxy::OutgoingMessageFilter* LoadExternalIPCDumper(
> > On 2016/06/07 18:53:41, jochen wrote:
> > > should be possible to move the call to this API to inside content, no?
> > > 
> > > then we wouldn't need a public API for this.
> > 
> > Done.
> 
> I'd prefer to make this part of the public API at the point when we need it.

OK, I've removed the CONTENT_EXPORT from the switches, and the APIs were already
moved to content/common. Do you have any other concerns?

[jochen (gone - plz use gerrit), 2016-06-08 15:21:22]

lgtm

[Oliver Chang, 2016-06-08 15:48:05]

The CQ bit was checked by ochang@chromium.org

[Oliver Chang, 2016-06-08 15:48:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
mbarbella@chromium.org
Link to the patchset: https://codereview.chromium.org/2043933002/#ps120001
(title: "remove CONTENT_EXPORT")

[commit-bot: I haz the power, 2016-06-08 15:48:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043933002/120001

[commit-bot: I haz the power, 2016-06-08 16:39:13]

Description was changed from

==========
Move IPC fuzzer switches and helpers from chrome/common to content/common.

BUG=607649
==========

to

==========
Move IPC fuzzer switches and helpers from chrome/common to content/common.

BUG=607649
==========

[commit-bot: I haz the power, 2016-06-08 16:39:15]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-06-08 16:40:31]

Description was changed from

==========
Move IPC fuzzer switches and helpers from chrome/common to content/common.

BUG=607649
==========

to

==========
Move IPC fuzzer switches and helpers from chrome/common to content/common.

BUG=607649

Committed: https://crrev.com/dd89a1e1f3f9e283d157f4edb9d419c899f36bf4
Cr-Commit-Position: refs/heads/master@{#398595}
==========

[commit-bot: I haz the power, 2016-06-08 16:40:32]

Patchset 5 (id:??) landed as
https://crrev.com/dd89a1e1f3f9e283d157f4edb9d419c899f36bf4
Cr-Commit-Position: refs/heads/master@{#398595}