Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Unified Diff: components/test_runner/test_runner.cc

Issue 2043923002: Replicate more dump_foo layout test runtime flags across OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replicate-can-open-windows
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index d23078b3a6439c5e52c7471e63ced86764de9968..c499cb46e3dfc2a62c35e47205f752121507d691 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -1604,9 +1604,6 @@ void TestRunner::Reset() {
}
dump_as_audio_ = false;
- dump_create_view_ = false;
- dump_window_status_changes_ = false;
- dump_spell_check_callbacks_ = false;
dump_back_forward_list_ = false;
test_repaint_ = false;
sweep_horizontally_ = false;
@@ -1777,7 +1774,7 @@ bool TestRunner::shouldDumpIconChanges() const {
}
bool TestRunner::shouldDumpCreateView() const {
- return dump_create_view_;
+ return layout_test_runtime_flags_.dump_create_view();
}
bool TestRunner::canOpenWindows() const {
@@ -1804,11 +1801,11 @@ void TestRunner::InitializeWebViewWithMocks(blink::WebView* web_view) {
}
bool TestRunner::shouldDumpStatusCallbacks() const {
- return dump_window_status_changes_;
+ return layout_test_runtime_flags_.dump_window_status_changes();
}
bool TestRunner::shouldDumpSpellCheckCallbacks() const {
- return dump_spell_check_callbacks_;
+ return layout_test_runtime_flags_.dump_spell_check_callbacks();
}
bool TestRunner::ShouldDumpBackForwardList() const {
@@ -2428,7 +2425,8 @@ void TestRunner::DumpTitleChanges() {
}
void TestRunner::DumpCreateView() {
- dump_create_view_ = true;
+ layout_test_runtime_flags_.set_dump_create_view(true);
+ OnLayoutTestRuntimeFlagsChanged();
}
void TestRunner::SetCanOpenWindows() {
@@ -2488,11 +2486,13 @@ void TestRunner::DumpPermissionClientCallbacks() {
}
void TestRunner::DumpWindowStatusChanges() {
- dump_window_status_changes_ = true;
+ layout_test_runtime_flags_.set_dump_window_status_changes(true);
+ OnLayoutTestRuntimeFlagsChanged();
}
void TestRunner::DumpSpellCheckCallbacks() {
- dump_spell_check_callbacks_ = true;
+ layout_test_runtime_flags_.set_dump_spell_check_callbacks(true);
+ OnLayoutTestRuntimeFlagsChanged();
}
void TestRunner::DumpBackForwardList() {
« components/test_runner/test_runner.h ('K') | « components/test_runner/test_runner.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698