Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2043903002: Move didChangeCursor calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: inspector overlay Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index 795309b67d7bca53c075e5d11263dec0e9659ddf..235b3b113ba6c45936889eec96adc2858fdcef3e 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -142,7 +142,10 @@ public:
void setCursor(const Cursor& cursor, LocalFrame* localRoot) override
{
toChromeClientImpl(m_client)->setCursorOverridden(false);
- toChromeClientImpl(m_client)->setCursor(cursor, localRoot);
+ // TODO(lfg): Inspector overlay should be fixed to work with
+ // out-of-process iframes. For now, just assume there's a single
+ // widget.
+ toChromeClientImpl(m_client)->setCursor(cursor, static_cast<WebViewImpl*>(toChromeClientImpl(m_client)->webView())->mainFrameImpl()->frame());
dcheng 2016/07/07 01:49:12 +dgozman, is it actually possible for there to be
dgozman 2016/07/07 02:02:26 You mean in inspector overlay page? Nope, we don't
dgozman 2016/07/07 02:02:26 m_overlay->m_webViewImpl->mainFrameImpl()->frame()
lfg 2016/07/07 14:36:21 Done.
bool overrideCursor = m_overlay->m_layoutEditor;
toChromeClientImpl(m_client)->setCursorOverridden(overrideCursor);
}

Powered by Google App Engine
This is Rietveld 408576698