Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 2043903002: Move didChangeCursor calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 void layoutUpdated(LocalFrame*) const override; 110 void layoutUpdated(LocalFrame*) const override;
111 void showMouseOverURL(const HitTestResult&) override; 111 void showMouseOverURL(const HitTestResult&) override;
112 void setToolTip(const String& tooltipText, TextDirection) override; 112 void setToolTip(const String& tooltipText, TextDirection) override;
113 void dispatchViewportPropertiesDidChange(const ViewportDescription&) const o verride; 113 void dispatchViewportPropertiesDidChange(const ViewportDescription&) const o verride;
114 void printDelegate(LocalFrame*) override; 114 void printDelegate(LocalFrame*) override;
115 void annotatedRegionsChanged() override; 115 void annotatedRegionsChanged() override;
116 ColorChooser* openColorChooser(LocalFrame*, ColorChooserClient*, const Color &) override; 116 ColorChooser* openColorChooser(LocalFrame*, ColorChooserClient*, const Color &) override;
117 DateTimeChooser* openDateTimeChooser(DateTimeChooserClient*, const DateTimeC hooserParameters&) override; 117 DateTimeChooser* openDateTimeChooser(DateTimeChooserClient*, const DateTimeC hooserParameters&) override;
118 void openFileChooser(LocalFrame*, PassRefPtr<FileChooser>) override; 118 void openFileChooser(LocalFrame*, PassRefPtr<FileChooser>) override;
119 void enumerateChosenDirectory(FileChooser*) override; 119 void enumerateChosenDirectory(FileChooser*) override;
120 void setCursor(const Cursor&, LocalFrame* localRoot) override; 120 void setCursor(const Cursor&, LocalFrame*) override;
121 Cursor lastSetCursorForTesting() const override; 121 Cursor lastSetCursorForTesting() const override;
122 void setEventListenerProperties(WebEventListenerClass, WebEventListenerPrope rties) override; 122 void setEventListenerProperties(WebEventListenerClass, WebEventListenerPrope rties) override;
123 WebEventListenerProperties eventListenerProperties(WebEventListenerClass) co nst override; 123 WebEventListenerProperties eventListenerProperties(WebEventListenerClass) co nst override;
124 void setHasScrollEventHandlers(bool hasEventHandlers) override; 124 void setHasScrollEventHandlers(bool hasEventHandlers) override;
125 bool hasScrollEventHandlers() const override; 125 bool hasScrollEventHandlers() const override;
126 void setTouchAction(TouchAction) override; 126 void setTouchAction(TouchAction) override;
127 127
128 // Pass 0 as the GraphicsLayer to detatch the root layer. 128 // Pass 0 as the GraphicsLayer to detatch the root layer.
129 void attachRootGraphicsLayer(GraphicsLayer*, LocalFrame* localRoot) override ; 129 void attachRootGraphicsLayer(GraphicsLayer*, LocalFrame* localRoot) override ;
130 130
131 void didPaint(const PaintArtifact&) override; 131 void didPaint(const PaintArtifact&) override;
132 132
133 void attachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFr ame*) override; 133 void attachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFr ame*) override;
134 void detachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFr ame*) override; 134 void detachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFr ame*) override;
135 135
136 void enterFullScreenForElement(Element*) override; 136 void enterFullScreenForElement(Element*) override;
137 void exitFullScreenForElement(Element*) override; 137 void exitFullScreenForElement(Element*) override;
138 138
139 void clearCompositedSelection() override; 139 void clearCompositedSelection() override;
140 void updateCompositedSelection(const CompositedSelection&) override; 140 void updateCompositedSelection(const CompositedSelection&) override;
141 141
142 // ChromeClient methods: 142 // ChromeClient methods:
143 void postAccessibilityNotification(AXObject*, AXObjectCache::AXNotification) override; 143 void postAccessibilityNotification(AXObject*, AXObjectCache::AXNotification) override;
144 String acceptLanguages() override; 144 String acceptLanguages() override;
145 145
146 // ChromeClientImpl: 146 // ChromeClientImpl:
147 void setCursorForPlugin(const WebCursorInfo&, LocalFrame* localRoot); 147 void setCursorForPlugin(const WebCursorInfo&, LocalFrame*);
148 void setNewWindowNavigationPolicy(WebNavigationPolicy); 148 void setNewWindowNavigationPolicy(WebNavigationPolicy);
149 void setCursorOverridden(bool); 149 void setCursorOverridden(bool);
150 150
151 bool hasOpenedPopup() const override; 151 bool hasOpenedPopup() const override;
152 PopupMenu* openPopupMenu(LocalFrame&, HTMLSelectElement&) override; 152 PopupMenu* openPopupMenu(LocalFrame&, HTMLSelectElement&) override;
153 PagePopup* openPagePopup(PagePopupClient*); 153 PagePopup* openPagePopup(PagePopupClient*);
154 void closePagePopup(PagePopup*); 154 void closePagePopup(PagePopup*);
155 DOMWindow* pagePopupWindowForTesting() const override; 155 DOMWindow* pagePopupWindowForTesting() const override;
156 156
157 bool shouldOpenModalDialogDuringPageDismissal(const DialogType&, const Strin g& dialogMessage, Document::PageDismissalType) const override; 157 bool shouldOpenModalDialogDuringPageDismissal(const DialogType&, const Strin g& dialogMessage, Document::PageDismissalType) const override;
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 190
191 void notifyPopupOpeningObservers() const; 191 void notifyPopupOpeningObservers() const;
192 192
193 private: 193 private:
194 explicit ChromeClientImpl(WebViewImpl*); 194 explicit ChromeClientImpl(WebViewImpl*);
195 195
196 bool isChromeClientImpl() const override { return true; } 196 bool isChromeClientImpl() const override { return true; }
197 void registerPopupOpeningObserver(PopupOpeningObserver*) override; 197 void registerPopupOpeningObserver(PopupOpeningObserver*) override;
198 void unregisterPopupOpeningObserver(PopupOpeningObserver*) override; 198 void unregisterPopupOpeningObserver(PopupOpeningObserver*) override;
199 199
200 void setCursor(const WebCursorInfo&, LocalFrame* localRoot); 200 void setCursor(const WebCursorInfo&, LocalFrame*);
201 201
202 WebViewImpl* m_webView; // Weak pointer. 202 WebViewImpl* m_webView; // Weak pointer.
203 WindowFeatures m_windowFeatures; 203 WindowFeatures m_windowFeatures;
204 Vector<PopupOpeningObserver*> m_popupOpeningObservers; 204 Vector<PopupOpeningObserver*> m_popupOpeningObservers;
205 Cursor m_lastSetMouseCursorForTesting; 205 Cursor m_lastSetMouseCursorForTesting;
206 bool m_cursorOverridden; 206 bool m_cursorOverridden;
207 bool m_didRequestNonEmptyToolTip; 207 bool m_didRequestNonEmptyToolTip;
208 }; 208 };
209 209
210 DEFINE_TYPE_CASTS(ChromeClientImpl, ChromeClient, client, client->isChromeClient Impl(), client.isChromeClientImpl()); 210 DEFINE_TYPE_CASTS(ChromeClientImpl, ChromeClient, client, client->isChromeClient Impl(), client.isChromeClientImpl());
211 211
212 } // namespace blink 212 } // namespace blink
213 213
214 #endif 214 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698