Move didChangeCursor calls from WebViewClient to WebWidgetClient.

Move didChangeCursor calls from WebViewClient to WebWidgetClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
Committed: https://crrev.com/d68bc0e260586cca8171a54863c5a409bb39a1a9
Cr-Commit-Position: refs/heads/master@{#405202}

[lfg, 2016-06-06 21:04:01]

Description was changed from

==========
Move didChangeCursor from WebViewClient to WebWidgetClient.o

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Move didChangeCursor from WebViewClient to WebWidgetClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

[lfg, 2016-06-06 21:25:53]

Description was changed from

==========
Move didChangeCursor from WebViewClient to WebWidgetClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Move didChangeCursor calls from WebViewClient to WebWidgetClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

[lfg, 2016-07-05 14:09:59]

Patchset #2 (id:20001) has been deleted

[lfg, 2016-07-05 20:11:14]

lfg@chromium.org changed reviewers:
+ dcheng@chromium.org

[lfg, 2016-07-05 20:11:15]

Please take a look.

[dcheng, 2016-07-07 01:49:11]

dcheng@chromium.org changed reviewers:
+ dgozman@chromium.org

[dcheng, 2016-07-07 01:49:12]

LGTM with a question for dgozman.

https://codereview.chromium.org/2043903002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/2043903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/ChromeClientImpl.cpp:741: void
ChromeClientImpl::setCursor(const WebCursorInfo& cursor, LocalFrame* localFrame)
Please update the caller in FrameView to just pass the frame directly, since
you're changing this to always find the local root.

https://codereview.chromium.org/2043903002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/InspectorOverlay.cpp (right):

https://codereview.chromium.org/2043903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/InspectorOverlay.cpp:148:
toChromeClientImpl(m_client)->setCursor(cursor,
static_cast<WebViewImpl*>(toChromeClientImpl(m_client)->webView())->mainFrameImpl()->frame());
+dgozman, is it actually possible for there to be OOPI in an inspector overlay?

[dgozman, 2016-07-07 02:02:26]

https://codereview.chromium.org/2043903002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/InspectorOverlay.cpp (right):

https://codereview.chromium.org/2043903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/InspectorOverlay.cpp:148:
toChromeClientImpl(m_client)->setCursor(cursor,
static_cast<WebViewImpl*>(toChromeClientImpl(m_client)->webView())->mainFrameImpl()->frame());
On 2016/07/07 01:49:12, dcheng wrote:
> +dgozman, is it actually possible for there to be OOPI in an inspector
overlay?

You mean in inspector overlay page? Nope, we don't even have iframes there.

https://codereview.chromium.org/2043903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/InspectorOverlay.cpp:148:
toChromeClientImpl(m_client)->setCursor(cursor,
static_cast<WebViewImpl*>(toChromeClientImpl(m_client)->webView())->mainFrameImpl()->frame());
m_overlay->m_webViewImpl->mainFrameImpl()->frame()

[lfg, 2016-07-07 14:36:22]

https://codereview.chromium.org/2043903002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/2043903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/ChromeClientImpl.cpp:741: void
ChromeClientImpl::setCursor(const WebCursorInfo& cursor, LocalFrame* localFrame)
On 2016/07/07 01:49:12, dcheng wrote:
> Please update the caller in FrameView to just pass the frame directly, since
> you're changing this to always find the local root.

Done.

https://codereview.chromium.org/2043903002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/InspectorOverlay.cpp (right):

https://codereview.chromium.org/2043903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/InspectorOverlay.cpp:148:
toChromeClientImpl(m_client)->setCursor(cursor,
static_cast<WebViewImpl*>(toChromeClientImpl(m_client)->webView())->mainFrameImpl()->frame());
On 2016/07/07 02:02:26, dgozman wrote:
> m_overlay->m_webViewImpl->mainFrameImpl()->frame()

Done.

[lfg, 2016-07-07 14:38:10]

lfg@chromium.org changed reviewers:
+ nick@chromium.org

[lfg, 2016-07-07 14:38:10]

nick@chromium.org: Please review changes in 

content/

[ncarter (slow), 2016-07-07 19:22:40]

content rubber stamp lgtm

[dcheng, 2016-07-08 10:38:05]

https://codereview.chromium.org/2043903002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/InspectorOverlay.cpp (right):

https://codereview.chromium.org/2043903002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/InspectorOverlay.cpp:147: // widget.
Nit: I'm not sure this needs a TODO, I think it's safe to just assume this given
dgozman's comment?

[lfg, 2016-07-11 18:37:24]

https://codereview.chromium.org/2043903002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/InspectorOverlay.cpp (right):

https://codereview.chromium.org/2043903002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/InspectorOverlay.cpp:147: // widget.
On 2016/07/08 10:38:04, dcheng wrote:
> Nit: I'm not sure this needs a TODO, I think it's safe to just assume this
given
> dgozman's comment?

Done.

[lfg, 2016-07-11 21:11:07]

The CQ bit was checked by lfg@chromium.org

[lfg, 2016-07-11 21:11:07]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org,
nick@chromium.org
Link to the patchset: https://codereview.chromium.org/2043903002/#ps140001
(title: "removed todo")

[commit-bot: I haz the power, 2016-07-11 21:11:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 23:03:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 23:03:29]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lfg, 2016-07-11 23:07:08]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2016-07-11 23:08:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 01:14:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 01:14:57]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lfg, 2016-07-12 02:12:40]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2016-07-12 02:14:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 05:38:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 05:38:53]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lfg, 2016-07-12 19:15:21]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2016-07-12 19:17:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 22:28:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 22:28:43]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lfg, 2016-07-13 15:11:52]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2016-07-13 15:12:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 16:10:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 16:10:18]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[lfg, 2016-07-13 16:42:01]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2016-07-13 16:42:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 17:08:59]

Description was changed from

==========
Move didChangeCursor calls from WebViewClient to WebWidgetClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Move didChangeCursor calls from WebViewClient to WebWidgetClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

[commit-bot: I haz the power, 2016-07-13 17:09:01]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-07-13 17:09:35]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 17:10:27]

Description was changed from

==========
Move didChangeCursor calls from WebViewClient to WebWidgetClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Move didChangeCursor calls from WebViewClient to WebWidgetClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087

Committed: https://crrev.com/d68bc0e260586cca8171a54863c5a409bb39a1a9
Cr-Commit-Position: refs/heads/master@{#405202}
==========

[commit-bot: I haz the power, 2016-07-13 17:10:29]

Patchset 7 (id:??) landed as
https://crrev.com/d68bc0e260586cca8171a54863c5a409bb39a1a9
Cr-Commit-Position: refs/heads/master@{#405202}