Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2043893002: Migrate WaitableEvent to enum-based constructor in ppapi/nacl_irt (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WaitableEvent to enum-based constructor in ppapi/nacl_irt Changes made manually because clang-tidy doesn't interact well with cross-compile. BUG=612843 Committed: https://crrev.com/2f2f2948b161a068fa80d01de88ec463b8d294ec Cr-Commit-Position: refs/heads/master@{#398219}

Patch Set 1 #

Patch Set 2 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M ppapi/nacl_irt/manifest_service.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ppapi/nacl_irt/plugin_startup.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
gab
mseaborn PTAL and CQ if it LGTY, thanks
4 years, 6 months ago (2016-06-06 20:33:35 UTC) #2
Mark Seaborn
It looks like this fails to compile: ../../ppapi/nacl_irt/plugin_startup.cc:80:52: error: no type named 'MANUAL' in 'base::WaitableEvent' ...
4 years, 6 months ago (2016-06-06 22:19:12 UTC) #3
gab
On 2016/06/06 22:19:12, Mark Seaborn wrote: > It looks like this fails to compile: > ...
4 years, 6 months ago (2016-06-07 00:45:16 UTC) #4
Mark Seaborn
LGTM
4 years, 6 months ago (2016-06-07 04:07:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043893002/20001
4 years, 6 months ago (2016-06-07 04:08:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 04:14:54 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 04:16:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f2f2948b161a068fa80d01de88ec463b8d294ec
Cr-Commit-Position: refs/heads/master@{#398219}

Powered by Google App Engine
This is Rietveld 408576698