Remove Roboto fonts from the resource bundle

Remove Roboto fonts from the resource bundle

This should go in after
https://chromium-review.googlesource.com/#/c/349730/ is landed.

Update install-chromeos-fonts.py to install the latest notofonts
and roboto font packages for CrOS.

R=dzhioev
BUG=617281
TEST=OOBE screen still use Roboto
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/af7381ce97d6a16c617e14356b42dfa6dba39dfb
Cr-Commit-Position: refs/heads/master@{#406034}

[jungshik at Google, 2016-06-07 21:15:02]

Description was changed from

==========
Remove Roboto fonts from the resource bundle

This should go in after
https://chromium-review.googlesource.com/#/c/349730/ is landed.

R=dzhioev
BUG=617281
TEST=
==========

to

==========
Remove Roboto fonts from the resource bundle

This should go in after
https://chromium-review.googlesource.com/#/c/349730/ is landed.

R=dzhioev
BUG=617281
TEST=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dzhioev_at_google, 2016-06-07 23:23:12]

dzhioev@google.com changed reviewers:
+ dzhioev@google.com

[dzhioev_at_google, 2016-06-07 23:23:12]

Please remove reference to roboto_font.css from
chrome/browser/resources/chromeos/login/oobe.html

[jungshik at Google, 2016-06-13 10:18:07]

On 2016/06/07 23:23:12, dzhioev_at_google wrote:
> Please remove reference to roboto_font.css from
> chrome/browser/resources/chromeos/login/oobe.html

Thanks. Done in PS 2/3.   I deployed Chrome to my Chrome OS build with
https://chromium-review.googlesource.com/#/c/349730/. At first, I was afraid
that Arimo (Arial-equivalent) instead of ROboto is used in OOBE because 'before'
and 'after' images look a bit different. However, I verified that it's Roboto (I
rendered a few strings in OOBE on my Linux box and compared it with what I have
in OOBE). 

So, I think it's good to go ONCE the Chrome OS cl is landed and you approved it.

PTAL

[jungshik at Google, 2016-06-13 10:18:24]

Description was changed from

==========
Remove Roboto fonts from the resource bundle

This should go in after
https://chromium-review.googlesource.com/#/c/349730/ is landed.

R=dzhioev
BUG=617281
TEST=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove Roboto fonts from the resource bundle

This should go in after
https://chromium-review.googlesource.com/#/c/349730/ is landed.

R=dzhioev
BUG=617281
TEST=OOBE screen still use Roboto
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dzhioev_at_google, 2016-06-14 21:54:58]

On 2016/06/13 10:18:07, jungshik - ooo until Jul 5 wrote:
> On 2016/06/07 23:23:12, dzhioev_at_google wrote:
> > Please remove reference to roboto_font.css from
> > chrome/browser/resources/chromeos/login/oobe.html
> 
> Thanks. Done in PS 2/3.   I deployed Chrome to my Chrome OS build with
> https://chromium-review.googlesource.com/#/c/349730/. At first, I was afraid
> that Arimo (Arial-equivalent) instead of ROboto is used in OOBE because
'before'
> and 'after' images look a bit different. However, I verified that it's Roboto
(I
> rendered a few strings in OOBE on my Linux box and compared it with what I
have
> in OOBE). 
> 
> So, I think it's good to go ONCE the Chrome OS cl is landed and you approved
it.
> 
> PTAL

LGTM

[jungshik at Google, 2016-07-13 00:02:48]

jshin@chromium.org changed reviewers:
+ oshima@chromium.org

[jungshik at Google, 2016-07-13 00:02:49]

oshima@chromium.org: Please approve the removal of Roboto fonts as resource.
They're now available soon as a part of Chromium OS. 

Thanks

[jungshik at Google, 2016-07-13 00:23:18]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 00:25:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:51:29]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 02:51:30]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-07-14 14:03:14]

On 2016/07/13 00:02:49, jungshik at google wrote:
> mailto:oshima@chromium.org: Please approve the removal of Roboto fonts as
resource.
> They're now available soon as a part of Chromium OS. 
> 
> Thanks

What happens when I run chrome for chromeos on linux desktop? Do you think its
impact isn't big?

Many of us in chromeos UI team use linux desktop to develop UI features, and I
want to make sure we can continue doing so.

[jungshik at Google, 2016-07-16 05:08:41]

jshin@chromium.org changed reviewers:
+ derat@chromium.orgmak

[jungshik at Google, 2016-07-16 05:21:45]

On 2016/07/14 14:03:14, oshima wrote:
> On 2016/07/13 00:02:49, jungshik at google wrote:
> > mailto:oshima@chromium.org: Please approve the removal of Roboto fonts as
> resource.
> > They're now available soon as a part of Chromium OS. 
> > 
> > Thanks
> 
> What happens when I run chrome for chromeos on linux desktop? Do you think its
> impact isn't big?
> 
> Many of us in chromeos UI team use linux desktop to develop UI features, and I
> want to make sure we can continue doing so.

As a part of setting up Linux development environment for Chrome, chromeos_fonts
package is installed
( build/install-build-deps.sh ).  

I'll update build/linux/install-chromeos-fonts.py to retrieve the latest noto
and roboto.

[jungshik at Google, 2016-07-16 05:42:51]

Description was changed from

==========
Remove Roboto fonts from the resource bundle

This should go in after
https://chromium-review.googlesource.com/#/c/349730/ is landed.

R=dzhioev
BUG=617281
TEST=OOBE screen still use Roboto
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove Roboto fonts from the resource bundle

This should go in after
https://chromium-review.googlesource.com/#/c/349730/ is landed.

Update install-chromeos-fonts.py to install the latest notofonts
and roboto font packages for CrOS.

R=dzhioev
BUG=617281
TEST=OOBE screen still use Roboto
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[jungshik at Google, 2016-07-16 05:50:41]

Description was changed from

==========
Remove Roboto fonts from the resource bundle

This should go in after
https://chromium-review.googlesource.com/#/c/349730/ is landed.

Update install-chromeos-fonts.py to install the latest notofonts
and roboto font packages for CrOS.

R=dzhioev
BUG=617281
TEST=OOBE screen still use Roboto
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove Roboto fonts from the resource bundle

This should go in after
https://chromium-review.googlesource.com/#/c/349730/ is landed.

Update install-chromeos-fonts.py to install the latest notofonts
and roboto font packages for CrOS.

R=dzhioev
BUG=617281
TEST=OOBE screen still use Roboto
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

[jungshik at Google, 2016-07-16 05:51:35]

jshin@chromium.org changed reviewers:
+ thestig@chromium.org

[jungshik at Google, 2016-07-16 05:51:36]

thestig@chromium.org: Please review changes in 

Can you take a look at build/linux changes? 
Thanks

[Lei Zhang, 2016-07-16 05:55:10]

lgtm

[oshima, 2016-07-16 06:45:40]

lgtm

[jungshik at Google, 2016-07-18 17:00:52]

The CQ bit was checked by jshin@chromium.org

[jungshik at Google, 2016-07-18 17:00:53]

The patchset sent to the CQ was uploaded after l-g-t-m from dzhioev@google.com
Link to the patchset: https://codereview.chromium.org/2043883004/#ps60001
(title: "Update chromeos font install script")

[commit-bot: I haz the power, 2016-07-18 17:02:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 17:02:21]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-18 18:06:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-18 18:07:08]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 18:10:51]

Description was changed from

==========
Remove Roboto fonts from the resource bundle

This should go in after
https://chromium-review.googlesource.com/#/c/349730/ is landed.

Update install-chromeos-fonts.py to install the latest notofonts
and roboto font packages for CrOS.

R=dzhioev
BUG=617281
TEST=OOBE screen still use Roboto
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove Roboto fonts from the resource bundle

This should go in after
https://chromium-review.googlesource.com/#/c/349730/ is landed.

Update install-chromeos-fonts.py to install the latest notofonts
and roboto font packages for CrOS.

R=dzhioev
BUG=617281
TEST=OOBE screen still use Roboto
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/af7381ce97d6a16c617e14356b42dfa6dba39dfb
Cr-Commit-Position: refs/heads/master@{#406034}
==========

[commit-bot: I haz the power, 2016-07-18 18:10:52]

Patchset 4 (id:??) landed as
https://crrev.com/af7381ce97d6a16c617e14356b42dfa6dba39dfb
Cr-Commit-Position: refs/heads/master@{#406034}