Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2043883003: Re-enable TestMemoryInfra browser tests (Closed)

Created:
4 years, 6 months ago by ssid
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable TestMemoryInfra browser tests The single process memory infra tests were failing because the number of tracing categories exceeded the MAX_CATEGORY_GROUPS. This is increased to 200 to suit the needs of single proecss mode (WebView). BUG=594884 TBR=brettw@chromium.org Committed: https://crrev.com/84b8d0d550280accd6b53af42b0899cda78cdb67 Cr-Commit-Position: refs/heads/master@{#399267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M base/trace_event/trace_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/tracing_browsertest.cc View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
ssid
+oysteine ptal, thanks.
4 years, 6 months ago (2016-06-07 20:28:14 UTC) #2
ssid
On 2016/06/07 20:28:14, ssid wrote: > +oysteine ptal, thanks. Note that this is just a ...
4 years, 6 months ago (2016-06-07 20:29:15 UTC) #3
oystein (OOO til 10th of July)
lgtm
4 years, 6 months ago (2016-06-10 14:06:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043883003/1
4 years, 6 months ago (2016-06-10 14:06:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/198818)
4 years, 6 months ago (2016-06-10 14:12:00 UTC) #8
ssid
+brettw PTAL, thanks.
4 years, 6 months ago (2016-06-10 16:34:35 UTC) #10
brettw
lgtm
4 years, 6 months ago (2016-06-10 21:01:19 UTC) #12
ssid
On 2016/06/10 16:34:35, ssid wrote: > +brettw > PTAL, thanks. TBRing brettw since this just ...
4 years, 6 months ago (2016-06-10 21:01:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043883003/1
4 years, 6 months ago (2016-06-10 21:02:49 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 21:09:18 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 21:09:20 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 21:12:17 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84b8d0d550280accd6b53af42b0899cda78cdb67
Cr-Commit-Position: refs/heads/master@{#399267}

Powered by Google App Engine
This is Rietveld 408576698