Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: third_party/WebKit/Source/platform/mac/VersionUtilMacTest.mm

Issue 2043883002: mac: Delete some pre-OS X 10.9 code in blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/mac/VersionUtilMac.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "platform/mac/VersionUtilMac.h" 5 #import "platform/mac/VersionUtilMac.h"
6 6
7 #include <AppKit/AppKit.h> 7 #include <AppKit/AppKit.h>
8 #include <gtest/gtest.h> 8 #include <gtest/gtest.h>
9 9
10 #ifndef NSAppKitVersionNumber10_7
11 #define NSAppKitVersionNumber10_7 1138
12 #endif
13
14 #ifndef NSAppKitVersionNumber10_9 10 #ifndef NSAppKitVersionNumber10_9
15 #define NSAppKitVersionNumber10_9 1265 11 #define NSAppKitVersionNumber10_9 1265
16 #endif 12 #endif
17 13
18 #ifndef NSAppKitVersionNumber10_10 14 #ifndef NSAppKitVersionNumber10_10
19 #define NSAppKitVersionNumber10_10 1343 15 #define NSAppKitVersionNumber10_10 1343
20 #endif 16 #endif
21 17
22 // This number was determined by writing a tiny Cocoa App on 10.10.4. 18 // This number was determined by writing a tiny Cocoa App on 10.10.4.
23 #define NSAppKitVersionNumber10_10Max 1348 19 #define NSAppKitVersionNumber10_10Max 1348
24 20
25 // This number was measured on OSX 10.11 Beta 15A234d. The 10.11 21 // This number was measured on OSX 10.11 Beta 15A234d. The 10.11
26 // AppKit.framework does not provide an NSAppKitVersionNumber preprocessor 22 // AppKit.framework does not provide an NSAppKitVersionNumber preprocessor
27 // definition for OSX 10.11. 23 // definition for OSX 10.11.
28 #define NSAppKitVersionNumber10_11Max 1389 24 #define NSAppKitVersionNumber10_11Max 1389
29 25
30 // AppKit version is loosely correlated to OSX version. It's still useful as a 26 // AppKit version is loosely correlated to OSX version. It's still useful as a
31 // sanity check in unit tests, though we don't want to rely on it in production 27 // sanity check in unit tests, though we don't want to rely on it in production
32 // code. 28 // code.
33 TEST(VersionUtilMac, AppKitVersions) 29 TEST(VersionUtilMac, AppKitVersions)
34 { 30 {
35 if (floor(NSAppKitVersionNumber) <= NSAppKitVersionNumber10_7) {
36 EXPECT_TRUE(blink::IsOSLionOrEarlier());
37 EXPECT_TRUE(blink::IsOSMavericksOrEarlier());
38 EXPECT_FALSE(blink::IsOSMavericks());
39 EXPECT_FALSE(blink::IsOSYosemite());
40 EXPECT_FALSE(blink::IsOSElCapitan());
41 return;
42 }
43
44 if (floor(NSAppKitVersionNumber) < NSAppKitVersionNumber10_9) {
45 EXPECT_FALSE(blink::IsOSLionOrEarlier());
46 EXPECT_TRUE(blink::IsOSMavericksOrEarlier());
47 EXPECT_FALSE(blink::IsOSMavericks());
48 EXPECT_FALSE(blink::IsOSYosemite());
49 EXPECT_FALSE(blink::IsOSElCapitan());
50 return;
51 }
52
53 if (floor(NSAppKitVersionNumber) == NSAppKitVersionNumber10_9) { 31 if (floor(NSAppKitVersionNumber) == NSAppKitVersionNumber10_9) {
54 EXPECT_FALSE(blink::IsOSLionOrEarlier());
55 EXPECT_TRUE(blink::IsOSMavericksOrEarlier());
56 EXPECT_TRUE(blink::IsOSMavericks()); 32 EXPECT_TRUE(blink::IsOSMavericks());
57 EXPECT_FALSE(blink::IsOSYosemite()); 33 EXPECT_FALSE(blink::IsOSYosemite());
58 EXPECT_FALSE(blink::IsOSElCapitan()); 34 EXPECT_FALSE(blink::IsOSElCapitan());
59 return; 35 return;
60 } 36 }
61 37
62 if (floor(NSAppKitVersionNumber) <= NSAppKitVersionNumber10_10Max && 38 if (floor(NSAppKitVersionNumber) <= NSAppKitVersionNumber10_10Max &&
63 floor(NSAppKitVersionNumber) >= NSAppKitVersionNumber10_10) { 39 floor(NSAppKitVersionNumber) >= NSAppKitVersionNumber10_10) {
64 EXPECT_FALSE(blink::IsOSLionOrEarlier());
65 EXPECT_FALSE(blink::IsOSMavericksOrEarlier());
66 EXPECT_FALSE(blink::IsOSMavericks()); 40 EXPECT_FALSE(blink::IsOSMavericks());
67 EXPECT_TRUE(blink::IsOSYosemite()); 41 EXPECT_TRUE(blink::IsOSYosemite());
68 EXPECT_FALSE(blink::IsOSElCapitan()); 42 EXPECT_FALSE(blink::IsOSElCapitan());
69 return; 43 return;
70 } 44 }
71 45
72 if (floor(NSAppKitVersionNumber) == NSAppKitVersionNumber10_11Max) { 46 if (floor(NSAppKitVersionNumber) == NSAppKitVersionNumber10_11Max) {
73 EXPECT_FALSE(blink::IsOSLionOrEarlier());
74 EXPECT_FALSE(blink::IsOSMavericksOrEarlier());
75 EXPECT_FALSE(blink::IsOSMavericks()); 47 EXPECT_FALSE(blink::IsOSMavericks());
76 EXPECT_FALSE(blink::IsOSYosemite()); 48 EXPECT_FALSE(blink::IsOSYosemite());
77 EXPECT_TRUE(blink::IsOSElCapitan()); 49 EXPECT_TRUE(blink::IsOSElCapitan());
78 return; 50 return;
79 } 51 }
80 } 52 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/mac/VersionUtilMac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698