Change time_t conversion operator to ToTime_t() function

Change time_t conversion operator to ToTime_t() function

In class CPDFSDK_DateTime, use ToTime_t() function to make the
conversion more clear.

Also, clean up the code in this class by removing buggy/unused code,
using static_cast instead of c cast etc.

Committed: https://pdfium.googlesource.com/pdfium/+/b7a5179a7cd73d33355e1cece763caf238b7dc22

[Wei Li, 2016-06-08 01:15:24]

Description was changed from

==========
Change time_t conversion operator to ToTime_t() function

In class CPDFSDK_DateTime, use ToTime_t() function to make the
conversion more clear.
==========

to

==========
Change time_t conversion operator to ToTime_t() function

In class CPDFSDK_DateTime, use ToTime_t() function to make the
conversion more clear.

Also, clean up the code in this class by removing buggy/unused code,
using static_cast instead of c cast etc.
==========

[Wei Li, 2016-06-08 01:27:15]

Patchset #2 (id:20001) has been deleted

[Wei Li, 2016-06-08 02:00:17]

Patchset #2 (id:40001) has been deleted

[Wei Li, 2016-06-08 02:28:37]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org

[Wei Li, 2016-06-08 02:28:37]

for review, thanks

[dsinclair, 2016-06-08 13:15:14]

lgtm w/ nit

https://codereview.chromium.org/2043873006/diff/60001/fpdfsdk/fsdk_baseannot.cpp
File fpdfsdk/fsdk_baseannot.cpp (right):

https://codereview.chromium.org/2043873006/diff/60001/fpdfsdk/fsdk_baseannot....
fpdfsdk/fsdk_baseannot.cpp:151: if (strLength > 0) {
nit: make this an early return?

[Tom Sepez, 2016-06-08 16:52:15]

lgtm

[Wei Li, 2016-06-08 16:58:56]

thanks

https://codereview.chromium.org/2043873006/diff/60001/fpdfsdk/fsdk_baseannot.cpp
File fpdfsdk/fsdk_baseannot.cpp (right):

https://codereview.chromium.org/2043873006/diff/60001/fpdfsdk/fsdk_baseannot....
fpdfsdk/fsdk_baseannot.cpp:151: if (strLength > 0) {
On 2016/06/08 13:15:13, dsinclair wrote:
> nit: make this an early return?

Done.

[Wei Li, 2016-06-08 18:22:41]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-06-08 18:22:42]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2043873006/#ps80001
(title: "address comment")

[commit-bot: I haz the power, 2016-06-08 18:22:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043873006/80001

[commit-bot: I haz the power, 2016-06-08 18:41:03]

Description was changed from

==========
Change time_t conversion operator to ToTime_t() function

In class CPDFSDK_DateTime, use ToTime_t() function to make the
conversion more clear.

Also, clean up the code in this class by removing buggy/unused code,
using static_cast instead of c cast etc.
==========

to

==========
Change time_t conversion operator to ToTime_t() function

In class CPDFSDK_DateTime, use ToTime_t() function to make the
conversion more clear.

Also, clean up the code in this class by removing buggy/unused code,
using static_cast instead of c cast etc.

Committed:
https://pdfium.googlesource.com/pdfium/+/b7a5179a7cd73d33355e1cece763caf238b7...
==========

[commit-bot: I haz the power, 2016-06-08 18:41:04]

Committed patchset #3 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/b7a5179a7cd73d33355e1cece763caf238b7...