Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2043843003: [iOS/GN] Allow overriding parameters of "ios_app_bundle" in "test" template. (Closed)

Created:
4 years, 6 months ago by sdefresne
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS/GN] Allow overriding parameters of "ios_app_bundle" in "test" template. Allow the caller of the "test" template from //testing/test.gni to override some of the parameters or to provide additional values. This is required by downstream iOS tests. BUG=603100 Committed: https://crrev.com/9e147e0f2afa85229667da6bd3c2a7e15a6f9232 Cr-Commit-Position: refs/heads/master@{#398161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M testing/test.gni View 2 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 6 months ago (2016-06-06 18:10:17 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-06 23:27:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043843003/1
4 years, 6 months ago (2016-06-06 23:28:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 00:11:02 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 00:14:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e147e0f2afa85229667da6bd3c2a7e15a6f9232
Cr-Commit-Position: refs/heads/master@{#398161}

Powered by Google App Engine
This is Rietveld 408576698