Issue 2043843002: S390: Used RISBG in MacroAssembler::IndexToArrayOffset to improve performance.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -11 lines)			Patch
M	src/crankshaft/s390/lithium-codegen-s390.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/crankshaft/s390/lithium-codegen-s390.cc	View	1 2 3	12 chunks	+20 lines, -8 lines	0 comments	Download
M	src/s390/macro-assembler-s390.h	View	1 2 3	1 chunk	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

JoranSiu

https://codereview.chromium.org/2043843002/diff/20001/src/s390/macro-assembler-s390.h File src/s390/macro-assembler-s390.h (right): https://codereview.chromium.org/2043843002/diff/20001/src/s390/macro-assembler-s390.h#newcode1585 src/s390/macro-assembler-s390.h:1585: bool isSmi, bool key_not_negative) { maybe rename key_not_negative to ...

4 years, 6 months ago (2016-06-06 20:02:45 UTC) #1

JoranSiu

On 2016/06/06 20:02:45, JoranSiu wrote: > https://codereview.chromium.org/2043843002/diff/20001/src/s390/macro-assembler-s390.h > File src/s390/macro-assembler-s390.h (right): > > https://codereview.chromium.org/2043843002/diff/20001/src/s390/macro-assembler-s390.h#newcode1585 > ...

4 years, 6 months ago (2016-06-07 14:36:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043843002/60001

4 years, 6 months ago (2016-06-07 14:57:57 UTC) #4

commit-bot: I haz the power

4 years, 6 months ago (2016-06-07 15:21:53 UTC) #7

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/1f2eaa1c14dc70284109a0b1aafaf2328248eb14
Cr-Commit-Position: refs/heads/master@{#36796}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 2043843002: S390: Used RISBG in MacroAssembler::IndexToArrayOffset to improve performance. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixed compilation errors, added key_not_negative bool arg for IndexToArrayOffset #

Patch Set 3 : Changed key_not_negative to keyIsNonNegative. #

Patch Set 4 : Changed keyIsNotNegative to keyMaybeNegative (previous bool direction was incorrect). Added default… #

Messages