Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2886)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

Issue 2043833003: customtabs: Initialize the spare renderer using the new WebContents method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Proguard fix for a test. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
index fc65b68d8482d6552b6d909d0ff6c4939ed180c3..43d137f63e0dbfc68cf1c9b78e38c287c7a11f8e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
@@ -51,7 +51,6 @@ import org.chromium.chrome.browser.util.IntentUtils;
import org.chromium.chrome.browser.util.UrlUtilities;
import org.chromium.content.browser.ChildProcessCreationParams;
import org.chromium.content.browser.ChildProcessLauncher;
-import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.common.Referrer;
@@ -228,22 +227,11 @@ public class CustomTabsConnection {
return true;
}
- /**
- * Creates a spare {@link WebContents}, if none exists.
- *
- * Navigating to "about:blank" forces a lot of initialization to take place
- * here. This improves PLT. This navigation is never registered in the history, as
- * "about:blank" is filtered by CanAddURLToHistory.
- *
- * TODO(lizeb): Replace this with a cleaner method. See crbug.com/521729.
- */
+ /** Creates a spare {@link WebContents}, if none exists. */
private void createSpareWebContents() {
ThreadUtils.assertOnUiThread();
if (mSpareWebContents != null) return;
- mSpareWebContents = WebContentsFactory.createWebContents(false, false);
- if (mSpareWebContents != null) {
- mSpareWebContents.getNavigationController().loadUrl(new LoadUrlParams("about:blank"));
- }
+ mSpareWebContents = WebContentsFactory.createWebContentsWithWarmRenderer(false, false);
}
/** @return the URL converted to string, or null if it's invalid. */
@@ -361,15 +349,7 @@ public class CustomTabsConnection {
return null;
}
- /**
- * @return a spare WebContents, or null.
- *
- * This WebContents has already navigated to "about:blank". You have to call
- * {@link LoadUrlParams.setShouldReplaceCurrentEntry(true)} for the next
- * navigation to ensure that a back navigation doesn't lead to about:blank.
- *
- * TODO(lizeb): Update this when crbug.com/521729 is fixed.
- */
+ /** @return a spare WebContents, or null. */
WebContents takeSpareWebContents() {
ThreadUtils.assertOnUiThread();
WebContents result = mSpareWebContents;

Powered by Google App Engine
This is Rietveld 408576698