cc/ipc/surface_sequence.mojom - Issue 2043833002: Add SurfaceSequence mojom file to cc/ipc and edit corresponding GYP file

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/ipc/surface_sequence.mojom

Issue 2043833002: Add SurfaceSequence mojom file to cc/ipc and edit corresponding GYP file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change based on fsamuel's feedback Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module cc.mojom;

	6

	7 // A per-surface-namespace sequence number that's used to coordinate

	8 // dependencies between frames. A sequence number may be satisfied once, and

	9 // may be depended on once.
	Tom Sepez 2016/06/06 22:34:39 What are the consequences if an untrusted client d What are the consequences if an untrusted client doesn't obey these rules? Thanks. xlai (Olivia) 2016/06/07 15:17:03 Do you mean the consequences when someone mishandl Show quoted text On 2016/06/06 22:34:39, Tom Sepez wrote: > What are the consequences if an untrusted client doesn't obey these rules? > Thanks. Do you mean the consequences when someone mishandles cc::SurfaceSequence (which is the type getting automatically converted from this mojom struct)? I don't think that's an issue. First, the sole purpose of cc::SurfaceSequence is to ensure correct destruction order in Surfaces on browser side and they are handled only in these two functions (Surface::SatisfyDestructionDependencies and Surface::SatisfyDestructionDependencies). Anyone who intends to modify existing codes on Surface on browser would need to undergo scrutiny from owners. Second, in fact, we already have two traditional IPCs (FrameHostMsg_RequireSequence, FrameHostMsg_SatisfySequence) that are passing SurfaceSequence across processes to invoke the above-mentioned functions. So far nothing bad happens with these existing IPCs.
	10 // A surface sequence consists of an id namespace and a local sequence number.

	11 struct SurfaceSequence {

	12 uint32 id_namespace;

	13 uint32 sequence;

	14 };

	15

OLD	NEW

« cc/ipc/cc_ipc.gyp ('K') | « cc/ipc/struct_traits_unittest.cc ('k') | cc/ipc/surface_sequence.typemap » ('j') | no next file with comments »