Issue 204383002: Use asynchronous spellchecking in spelling-hasspellingmarker.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204383002: Use asynchronous spellchecking in spelling-hasspellingmarker.js (Closed)

Created:
6 years, 9 months ago by grzegorz

Modified:
6 years, 9 months ago

Reviewers:
tony, groby-ooo-7-16

CC:
blink-reviews, groby+blinkspell_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Use asynchronous spellchecking in spelling-hasspellingmarker.js Refactoring spelling-hasspellingmarker.js to use asynchronous spellchecking. In addition, adds some bits for non-DumpRenderTree users. It's based on WebKit changeset: http://trac.webkit.org/changeset/164100 BUG=295722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169636

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -22 lines)			Patch
M	LayoutTests/editing/spelling/script-tests/spelling-hasspellingmarker.js	View	1 chunk	+55 lines, -15 lines	0 comments	Download
M	LayoutTests/editing/spelling/spelling-hasspellingmarker.html	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/editing/spelling/spelling-hasspellingmarker-expected.txt	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

grzegorz

Are you willing to review another one? I'd appreciate it. Thanks.

6 years, 9 months ago (2014-03-19 09:44:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/204383002/1

6 years, 9 months ago (2014-03-20 07:25:03 UTC) #4

Message was sent while issue was closed.

Change committed as 169636