Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 2043813002: Revert of Suppress -Wnonportable-include-path on clang tot bots (Closed)

Created:
4 years, 6 months ago by hans
Modified:
4 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Suppress -Wnonportable-include-path on clang tot bots (patchset #2 id:20001 of https://codereview.chromium.org/2040533003/ ) Reason for revert: The Clang warning was removed again in r271761. Original issue's description: > Suppress -Wnonportable-include-path on clang tot bots > > BUG=617318 > R=hans@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/2bc751024e4ddf3f50594abdbf3c54b77df84562 TBR=thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=617318 Committed: https://crrev.com/2b359d2e5b4f7639055c9c6ff3ed39a03a2a3a0b Cr-Commit-Position: refs/heads/master@{#398065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hans
Created Revert of Suppress -Wnonportable-include-path on clang tot bots
4 years, 6 months ago (2016-06-06 16:36:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043813002/1
4 years, 6 months ago (2016-06-06 16:36:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 18:12:41 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2b359d2e5b4f7639055c9c6ff3ed39a03a2a3a0b Cr-Commit-Position: refs/heads/master@{#398065}
4 years, 6 months ago (2016-06-06 18:14:38 UTC) #6
Nico
4 years, 6 months ago (2016-06-14 14:20:33 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2069603002/ by thakis@chromium.org.

The reason for reverting is: Warning landed again upstream..

Powered by Google App Engine
This is Rietveld 408576698