Gamma sanity checks

Gamma sanity checks

(1) Make load_gammas() return false on invalid gammas.
(2) Assert that gamma always exists after loading.
(3) Avoid dividing by zero.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043803002

Committed: https://skia.googlesource.com/skia/+/a4fa4f6eb727e8b97f6d8a58d9fda4aea56bbc75

[msarett, 2016-06-06 16:12:28]

Description was changed from

==========
Gamma sanity checks

(1) Verify that load_gammas() returns false on invalid gammas.
(2) Assert that gamma always exists after loading.
(3) Avoid dividing by zero.

BUG=skia:
==========

to

==========
Gamma sanity checks

(1) Verify that load_gammas() returns false on invalid gammas.
(2) Assert that gamma always exists after loading.
(3) Avoid dividing by zero.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043803002
==========

[msarett, 2016-06-06 16:14:38]

Patchset #1 (id:1) has been deleted

[msarett, 2016-06-06 16:15:00]

Description was changed from

==========
Gamma sanity checks

(1) Verify that load_gammas() returns false on invalid gammas.
(2) Assert that gamma always exists after loading.
(3) Avoid dividing by zero.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043803002
==========

to

==========
Gamma sanity checks

(1) Make load_gammas() return false on invalid gammas.
(2) Assert that gamma always exists after loading.
(3) Avoid dividing by zero.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043803002
==========

[msarett, 2016-06-06 16:16:11]

Patchset #1 (id:20001) has been deleted

[msarett, 2016-06-06 16:19:20]

Patchset #1 (id:40001) has been deleted

[msarett, 2016-06-06 16:20:40]

msarett@google.com changed reviewers:
+ scroggo@google.com

[msarett, 2016-06-06 16:20:40]

There's still some checking to do in https://codereview.chromium.org/2038823002/
but I decided to split this off into its own CL.

[scroggo, 2016-06-06 17:13:54]

lgtm

https://codereview.chromium.org/2043803002/diff/60001/src/core/SkColorSpace.cpp
File src/core/SkColorSpace.cpp (right):

https://codereview.chromium.org/2043803002/diff/60001/src/core/SkColorSpace.c...
src/core/SkColorSpace.cpp:611: SkColorSpacePrintf("Constant gamma function is
nonsense");
It might help to differentiate these print statements so you can tell which one
it was.

[msarett, 2016-06-06 17:25:05]

https://codereview.chromium.org/2043803002/diff/60001/src/core/SkColorSpace.cpp
File src/core/SkColorSpace.cpp (right):

https://codereview.chromium.org/2043803002/diff/60001/src/core/SkColorSpace.c...
src/core/SkColorSpace.cpp:611: SkColorSpacePrintf("Constant gamma function is
nonsense");
On 2016/06/06 17:13:54, scroggo wrote:
> It might help to differentiate these print statements so you can tell which
one
> it was.

Done.

[msarett, 2016-06-06 17:25:10]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 17:25:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043803002/80001

[commit-bot: I haz the power, 2016-06-06 17:40:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 17:40:58]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-06-06 17:41:54]

The CQ bit was checked by msarett@google.com

[msarett, 2016-06-06 17:41:54]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/2043803002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-06-06 17:41:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043803002/80001

[commit-bot: I haz the power, 2016-06-06 17:42:53]

Description was changed from

==========
Gamma sanity checks

(1) Make load_gammas() return false on invalid gammas.
(2) Assert that gamma always exists after loading.
(3) Avoid dividing by zero.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043803002
==========

to

==========
Gamma sanity checks

(1) Make load_gammas() return false on invalid gammas.
(2) Assert that gamma always exists after loading.
(3) Avoid dividing by zero.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043803002

Committed:
https://skia.googlesource.com/skia/+/a4fa4f6eb727e8b97f6d8a58d9fda4aea56bbc75
==========

[commit-bot: I haz the power, 2016-06-06 17:42:54]

Committed patchset #2 (id:80001) as
https://skia.googlesource.com/skia/+/a4fa4f6eb727e8b97f6d8a58d9fda4aea56bbc75