Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2043783002: Resynthesize enums lazily. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resynthesize enums lazily. Now everything is resynthesized lazily, so we can remove 'unitHolder'. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2ef55609fc4d6a0ca9bb53151878991e1c526b8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -64 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +10 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 5 chunks +7 lines, -62 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 6 months ago (2016-06-06 15:49:02 UTC) #1
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-06-06 15:51:28 UTC) #2
Paul Berry
lgtm
4 years, 6 months ago (2016-06-06 15:54:07 UTC) #3
scheglov
4 years, 6 months ago (2016-06-06 15:55:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2ef55609fc4d6a0ca9bb53151878991e1c526b8c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698