Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2043763002: [Chromecast] Buildfix in Android PR codepath (Closed)

Created:
4 years, 6 months ago by halliwell
Modified:
4 years, 6 months ago
Reviewers:
yucliu1
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Buildfix in Android PR codepath Another mistake in https://codereview.chromium.org/2032923002/ |persistent_license_support_| was unused on Android. Rather than adding more ifdefs, just check that the caller isn't setting this to true on Android. BUG= Committed: https://crrev.com/86cd3e9b8c2afad32d5bf7ff4596016e6e8ad726 Cr-Commit-Position: refs/heads/master@{#398163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chromecast/renderer/key_systems_cast.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
halliwell
4 years, 6 months ago (2016-06-06 23:13:44 UTC) #3
yucliu1
On 2016/06/06 23:13:44, halliwell wrote: lgtm
4 years, 6 months ago (2016-06-06 23:17:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043763002/1
4 years, 6 months ago (2016-06-06 23:20:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 00:13:05 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 00:16:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86cd3e9b8c2afad32d5bf7ff4596016e6e8ad726
Cr-Commit-Position: refs/heads/master@{#398163}

Powered by Google App Engine
This is Rietveld 408576698