Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4371)

Unified Diff: chrome/browser/net/predictor_browsertest.cc

Issue 2043753002: Declarative resource hints go through mojo IPC to //content Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove gmocking + add another browser test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/predictor_browsertest.cc
diff --git a/chrome/browser/net/predictor_browsertest.cc b/chrome/browser/net/predictor_browsertest.cc
index 5395f044c9ee79c3bd0ad27231c747ea3c50bd14..a2fa31cec3c8e2a5a5fa06df4d1206582f30bbe1 100644
--- a/chrome/browser/net/predictor_browsertest.cc
+++ b/chrome/browser/net/predictor_browsertest.cc
@@ -36,7 +36,6 @@
#include "net/base/host_port_pair.h"
#include "net/base/ip_endpoint.h"
#include "net/base/net_errors.h"
-#include "net/dns/host_resolver_proc.h"
#include "net/dns/mock_host_resolver.h"
#include "net/http/http_transaction_factory.h"
#include "net/socket/stream_socket.h"
@@ -98,14 +97,6 @@ std::unique_ptr<net::test_server::HttpResponse> RedirectForPathHandler(
}
const char kBlinkPreconnectFeature[] = "LinkPreconnect";
-const char kChromiumUrl[] = "http://chromium.org";
-const char kInvalidLongUrl[] =
- "http://"
- "illegally-long-hostname-over-255-characters-should-not-send-an-ipc-"
- "message-to-the-browser-"
- "00000000000000000000000000000000000000000000000000000000000000000000000000"
- "00000000000000000000000000000000000000000000000000000000000000000000000000"
- "0000000000000000000000000000000000000000000000000000.org";
// Gets notified by the EmbeddedTestServer on incoming connections being
// accepted or read from, keeps track of them and exposes that info to
@@ -1385,25 +1376,12 @@ IN_PROC_BROWSER_TEST_F(PredictorBrowserTest, ShutdownStartupCyclePreresolve) {
EXPECT_FALSE(observer()->HostFound(target_url_));
}
-IN_PROC_BROWSER_TEST_F(PredictorBrowserTest, DnsPrefetch) {
- // Navigate once to make sure all initial hostnames are requested.
- ui_test_utils::NavigateToURL(browser(),
- embedded_test_server()->GetURL("/title1.html"));
-
- size_t hosts_looked_up_before_load = observer()->TotalHostsLookedUp();
-
- ui_test_utils::NavigateToURL(browser(), embedded_test_server()->GetURL(
- "/predictor/dns_prefetch.html"));
- observer()->WaitUntilHostLookedUp(GURL(kChromiumUrl));
- ASSERT_FALSE(observer()->HasHostBeenLookedUp(GURL(kInvalidLongUrl)));
-
- EXPECT_FALSE(observer()->HostFound(GURL(kChromiumUrl)));
- ASSERT_EQ(hosts_looked_up_before_load + 1, observer()->TotalHostsLookedUp());
-}
-
// Tests that preconnect warms up a socket connection to a test server.
// Note: This test uses a data URI to serve the preconnect hint, to make sure
// that the network stack doesn't just re-use its connection to the test server.
+// TODO(csharrison): Move these tests to //content/browser/loader. Now that
+// resource hints have migrated to live there. This might require sharing the
+// preconnect test harness logic.
IN_PROC_BROWSER_TEST_F(PredictorBrowserTest, PreconnectNonCORS) {
GURL preconnect_url = embedded_test_server()->base_url();
std::string preconnect_content =

Powered by Google App Engine
This is Rietveld 408576698