third_party/WebKit/Source/platform/PlatformMojoInterface.h - Issue 2043753002: Declarative resource hints go through mojo IPC to //content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/PlatformMojoInterface.h

Issue 2043753002: Declarative resource hints go through mojo IPC to //content Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use unique_ptr to avoid memory leaks in unit tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp ('K') | « third_party/WebKit/Source/platform/BUILD.gn ('k') | third_party/WebKit/Source/platform/PlatformMojoInterface.cpp » ('j') | third_party/WebKit/Source/platform/exported/Platform.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef PlatformMojoInterface_h

	6 #define PlatformMojoInterface_h

	7

	8 #include "public/platform/resource_hints.mojom-blink.h"

	9

	10 namespace blink {

	11

	12 class PlatformMojoInterface {
	kinuko 2016/06/16 05:39:58 nit: PlatformMojoInterface's'... or maybe Platform nit: PlatformMojoInterface's'... or maybe PlatformMojoServices (I slightly prefer latter, as what we're accessing through this are mojo services) Charlie Harrison 2016/06/16 11:00:20 Done. Show quoted text On 2016/06/16 at 05:39:58, kinuko wrote: > nit: PlatformMojoInterface's'... or maybe PlatformMojoServices (I slightly prefer latter, as what we're accessing through this are mojo services) Done.
	13 public:

	14 PlatformMojoInterface();

	15

	16 const mojom::blink::ResourceHintsHandlerPtr& resourceHintsHandlerHost();
	kinuko 2016/06/16 05:39:58 nit: why we add suffix 'Host' here? Just resourceH nit: why we add suffix 'Host' here? Just resourceHintsHandler() (or getResourceHintsHandler()) looks enough to me Charlie Harrison 2016/06/16 11:00:20 Done. Show quoted text On 2016/06/16 at 05:39:58, kinuko wrote: > nit: why we add suffix 'Host' here? Just resourceHintsHandler() (or getResourceHintsHandler()) looks enough to me Done.
	17

	18 private:

	19 mojom::blink::ResourceHintsHandlerPtr m_resourceHintsHandlerHost;

	20 };

	21

	22 } // namespace blink

	23

	24 #endif // PlatformMojoInterface_h

OLD	NEW