Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 2043743003: Switch CrWinClang to gn again. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch CrWinClang to gn again. This relands parts of https://codereview.chromium.org/1947183004/ Now that clobber runs as a separate step before runhooks, swarming should work on gn clobber bots. BUG=498033 Committed: https://crrev.com/9b6d81f1e5b090fbc9eabc88972d1e6cc4369c94 Cr-Commit-Position: refs/heads/master@{#398148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-06 21:00:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043743003/1
4 years, 6 months ago (2016-06-06 21:02:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 22:38:36 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9b6d81f1e5b090fbc9eabc88972d1e6cc4369c94 Cr-Commit-Position: refs/heads/master@{#398148}
4 years, 6 months ago (2016-06-06 22:40:15 UTC) #7
Nico
4 years, 6 months ago (2016-06-08 00:40:58 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2049583002/ by thakis@chromium.org.

The reason for reverting is: goma miscompiles things in optimized clang-cl
builds if -imsvc is used (which the gn build uses but the gyp build doesn't),
see https://crbug.com/618038.

Powered by Google App Engine
This is Rietveld 408576698