Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 204373003: Oilpan: Change references to MutableStylePropertySet to transition types. (Closed)

Created:
6 years, 9 months ago by wibling-chromium
Modified:
6 years, 9 months ago
CC:
blink-reviews, shans, fs, yurys+blink_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, loislo+blink_chromium.org, aandrey+blink_chromium.org, dino_apple.com, rwlbuis, krit, caseq+blink_chromium.org, Steve Block, alancutter (OOO until 2018), pfeldman+blink_chromium.org, Timothy Loh, dstockwell, dglazkov+blink, Rik, devtools-reviews_chromium.org, pdr., rune+blink, Eric Willigers, kenneth.christiansen, rjwright, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, gyuyoung.kim_webkit.org, darktears, alph+blink_chromium.org, kouhei+svg_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), groby+blinkspell_chromium.org, Stephen Chennney
Visibility:
Public.

Description

Oilpan: Change references to MutableStylePropertySet to transition types. Also moved the simple ViewportStyleResolver onto the heap. Next will change ImmutableStylePropertySet to transition types. R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org BUG=341815 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169546

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -80 lines) Patch
M Source/core/animation/EffectInput.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/DOMWindowCSS.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontFaceSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySet.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.h View 3 chunks +7 lines, -6 lines 2 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 3 chunks +7 lines, -4 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/EditingStyle.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 13 chunks +18 lines, -18 lines 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditorCommand.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElementRareData.h View 1 chunk +1 line, -1 line 2 comments Download
M Source/core/svg/SVGFontFaceElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
wibling-chromium
6 years, 9 months ago (2014-03-19 10:15:59 UTC) #1
haraken
LGTM https://codereview.chromium.org/204373003/diff/1/Source/core/css/resolver/ViewportStyleResolver.h File Source/core/css/resolver/ViewportStyleResolver.h (right): https://codereview.chromium.org/204373003/diff/1/Source/core/css/resolver/ViewportStyleResolver.h#newcode70 Source/core/css/resolver/ViewportStyleResolver.h:70: Document* m_document; This raw pointer is safe since ...
6 years, 9 months ago (2014-03-19 10:26:23 UTC) #2
wibling-chromium
Thanks for the review! https://codereview.chromium.org/204373003/diff/1/Source/core/css/resolver/ViewportStyleResolver.h File Source/core/css/resolver/ViewportStyleResolver.h (right): https://codereview.chromium.org/204373003/diff/1/Source/core/css/resolver/ViewportStyleResolver.h#newcode70 Source/core/css/resolver/ViewportStyleResolver.h:70: Document* m_document; On 2014/03/19 10:26:23, ...
6 years, 9 months ago (2014-03-19 10:33:18 UTC) #3
wibling-chromium
The CQ bit was checked by wibling@chromium.org
6 years, 9 months ago (2014-03-19 11:09:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/204373003/1
6 years, 9 months ago (2014-03-19 11:09:52 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 11:58:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-19 11:58:09 UTC) #7
wibling-chromium
The CQ bit was checked by wibling@chromium.org
6 years, 9 months ago (2014-03-19 12:01:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/204373003/1
6 years, 9 months ago (2014-03-19 12:01:44 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 12:43:11 UTC) #10
Message was sent while issue was closed. 
Change committed as 169546

Powered by Google App Engine
This is Rietveld 408576698