Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2043713006: [heap] Clear out of live range remembered set slots in large objects. (Closed)

Created:
4 years, 6 months ago by Hannes Payer (out of office)
Modified:
4 years, 6 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Clear out of live range remembered set slots in large objects. BUG=chromium:617882 LOG=n Committed: https://crrev.com/38ad63ff15d7e379423be4c57ae94ae2c9ffb4af Cr-Commit-Position: refs/heads/master@{#36795}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M src/heap/spaces.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/spaces.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-617882.js View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ulan
lgtm
4 years, 6 months ago (2016-06-07 14:31:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043713006/1
4 years, 6 months ago (2016-06-07 14:32:19 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/2777) v8_linux64_asan_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-06-07 14:46:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043713006/20001
4 years, 6 months ago (2016-06-07 14:53:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 15:19:35 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/38ad63ff15d7e379423be4c57ae94ae2c9ffb4af Cr-Commit-Position: refs/heads/master@{#36795}
4 years, 6 months ago (2016-06-07 15:21:52 UTC) #12
Michael Achenbach
4 years, 6 months ago (2016-06-07 18:27:49 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2042403002/ by machenbach@chromium.org.

The reason for reverting is: Fails arm sim:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20....

Powered by Google App Engine
This is Rietveld 408576698