mojo/public/cpp/bindings/lib/connector.cc - Issue 2043713004: Mojo: Add NotifyBadMessage API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/connector.cc

Issue 2043713004: Mojo: Add NotifyBadMessage API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/lib/connector.cc

diff --git a/mojo/public/cpp/bindings/lib/connector.cc b/mojo/public/cpp/bindings/lib/connector.cc

index 9f1037ceae81b09ef3948d6532b7f1cec9a524ff..a8104c24fcb82c9ad70d8ff993a777112f72f05c 100644

--- a/mojo/public/cpp/bindings/lib/connector.cc

+++ b/mojo/public/cpp/bindings/lib/connector.cc

@@ -266,9 +266,10 @@ bool Connector::ReadSingleMessage(MojoResult* read_result) {

const MojoResult rv = ReadMessage(message_pipe_.get(), &message);

*read_result = rv;

- if (rv == MOJO_RESULT_OK) {

- receiver_result =

- incoming_receiver_ && incoming_receiver_->Accept(&message);

+ if (rv == MOJO_RESULT_OK && incoming_receiver_) {

+ receiver_result = incoming_receiver_->Accept(&message);

+ if (!receiver_result)

+ message.NotifyBadMessage();

}

if (!weak_self)