Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2043703002: [Android, RemotePlayback] Make RemotePlayback classes ActiveScriptWrappable's (Closed)

Created:
4 years, 6 months ago by whywhat
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Android, RemotePlayback] Make RemotePlayback classes ActiveScriptWrappable's Keeps the V8 wrappers alive as long as there're event listeners or pending promises and such. BUG=616761 TEST=manual, see repro steps in the bug Review-Url: https://codereview.chromium.org/2038573002 Cr-Commit-Position: refs/heads/master@{#398014} (cherry picked from commit 10633dff101889d287c524266420f3b37dc7a23c) Committed: https://chromium.googlesource.com/chromium/src/+/1ac36391ca6c027b717c25f17026d3e9b9a9f3cd

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043703002/1
4 years, 6 months ago (2016-06-06 13:22:20 UTC) #2
commit-bot: I haz the power
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in ...
4 years, 6 months ago (2016-06-06 13:22:22 UTC) #4
whywhat
4 years, 6 months ago (2016-06-06 13:27:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ac36391ca6c027b717c25f17026d3e9b9a9f3cd.

Powered by Google App Engine
This is Rietveld 408576698