Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2043633002: Remove obsolete friend declarations for MSVC. (Closed)

Created:
4 years, 6 months ago by Yuta Kitamura
Modified:
4 years, 6 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete friend declarations for MSVC. These friend declarations were added because MSVC had a bug around the visibility of nested classes. They are no longer necessary. BUG=617504 Committed: https://crrev.com/8b06121b2024e23574d9f8423a326368e6cf6313 Cr-Commit-Position: refs/heads/master@{#398181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M third_party/WebKit/Source/platform/graphics/ContiguousContainer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageDecodingStore.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043633002/1
4 years, 6 months ago (2016-06-06 07:39:48 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 09:10:23 UTC) #4
Yuta Kitamura
tzik & kbr: PTAL? +kbr for approval in platform/graphics/.
4 years, 6 months ago (2016-06-06 09:21:33 UTC) #7
tzik
lgtm
4 years, 6 months ago (2016-06-06 09:36:08 UTC) #8
Ken Russell (switch to Gerrit)
lgtm
4 years, 6 months ago (2016-06-06 23:10:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043633002/1
4 years, 6 months ago (2016-06-07 00:56:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 01:03:23 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 01:04:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b06121b2024e23574d9f8423a326368e6cf6313
Cr-Commit-Position: refs/heads/master@{#398181}

Powered by Google App Engine
This is Rietveld 408576698