Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 204363002: Run mozilla and webkit of fast quickcheck archs as well (Closed)

Created:
6 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Run mozilla and webkit of fast quickcheck archs as well BUG=none R=svenpanne@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=20056

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Makefile View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
6 years, 9 months ago (2014-03-19 09:29:41 UTC) #1
Sven Panne
lgtm https://codereview.chromium.org/204363002/diff/1/Makefile File Makefile (right): https://codereview.chromium.org/204363002/diff/1/Makefile#newcode375 Makefile:375: SUPERFASTTESTMODES = ia32.release,x64.release What's next? RIDICULOUSLYFASTMODES? LUDICROUSLYFASTMODES? :-D
6 years, 9 months ago (2014-03-19 09:35:35 UTC) #2
Jakob Kummerow
DBC: Putting the additional logic "if ia32.release then run mozilla+webkit in addition to the default ...
6 years, 9 months ago (2014-03-19 09:52:09 UTC) #3
jochen (gone - plz use gerrit)
On 2014/03/19 09:52:09, Jakob wrote: > DBC: > Putting the additional logic "if ia32.release then ...
6 years, 9 months ago (2014-03-19 10:38:55 UTC) #4
Sven Panne
On 2014/03/19 10:38:55, jochen wrote: > I think spreading the logic what archs do what ...
6 years, 9 months ago (2014-03-19 10:44:29 UTC) #5
jochen (gone - plz use gerrit)
6 years, 9 months ago (2014-03-19 10:48:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r20056 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698