Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2043613002: Remove the use of OwnedPtrDeleter in HarfBuzzFace. (Closed)

Created:
4 years, 6 months ago by Yuta Kitamura
Modified:
4 years, 6 months ago
Reviewers:
drott, *tzik
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the use of OwnedPtrDeleter in HarfBuzzFace. It's hard to mechanically replace specializations of OwnedPtrDeleter<T> to std::unique_ptr equivalents. Therefore, they are converted to std::unique_ptr manually. The specializations in HarfBuzzFace.h are only used from HarfBuzzFace.cpp, so the new deleters are added in .cpp file. New typedefs are created so people can always use std::unique_ptr with a correct deleter. BUG=617504 Committed: https://crrev.com/4395bd8231b38b9b467f1141ccf0a4a7258f1f5c Cr-Commit-Position: refs/heads/master@{#397996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -28 lines) Patch
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp View 4 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043613002/1
4 years, 6 months ago (2016-06-06 07:30:26 UTC) #2
Yuta Kitamura
tzik & drott: PTAL?
4 years, 6 months ago (2016-06-06 07:31:10 UTC) #5
drott
LGTM
4 years, 6 months ago (2016-06-06 07:51:22 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 08:53:57 UTC) #8
tzik
lgtm
4 years, 6 months ago (2016-06-06 08:58:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043613002/1
4 years, 6 months ago (2016-06-06 09:15:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 09:19:52 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 09:22:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4395bd8231b38b9b467f1141ccf0a4a7258f1f5c
Cr-Commit-Position: refs/heads/master@{#397996}

Powered by Google App Engine
This is Rietveld 408576698