headless/lib/browser/headless_browser_main_parts.h - Issue 2043603004: headless: Introduce a browser context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/headless_browser_main_parts.h

Issue 2043603004: headless: Introduce a browser context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/browser/headless_browser_main_parts.h

diff --git a/headless/lib/browser/headless_browser_main_parts.h b/headless/lib/browser/headless_browser_main_parts.h

index 3b7453ecf9a5bc1db0b98d0e81c978b198d3b0bb..b0e30c397b8c7432c7a762d61244a08918ab0ddd 100644

--- a/headless/lib/browser/headless_browser_main_parts.h

+++ b/headless/lib/browser/headless_browser_main_parts.h

@@ -16,7 +16,7 @@ class DevToolsHttpHandler;

namespace headless {

-class HeadlessBrowserContext;

+class HeadlessBrowserContextImpl;

class HeadlessBrowserImpl;

class HeadlessBrowserMainParts : public content::BrowserMainParts {

@@ -28,11 +28,11 @@ class HeadlessBrowserMainParts : public content::BrowserMainParts {

void PreMainMessageLoopRun() override;

void PostMainMessageLoopRun() override;

- HeadlessBrowserContext* browser_context() const;

+ HeadlessBrowserContextImpl* default_browser_context() const;

private:

HeadlessBrowserImpl* browser_; // Not owned.

- std::unique_ptr<HeadlessBrowserContext> browser_context_;

+ std::unique_ptr<HeadlessBrowserContextImpl> browser_context_;

std::unique_ptr<devtools_http_handler::DevToolsHttpHandler>

devtools_http_handler_;