Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: headless/lib/browser/headless_browser_impl.h

Issue 2043603004: headless: Introduce a browser context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/browser/headless_browser_impl.h
diff --git a/headless/lib/browser/headless_browser_impl.h b/headless/lib/browser/headless_browser_impl.h
index 737a1f7e6103f25d3fdf601071e340a777e695ae..68dc676e5dd9acd9d07ebe90bb74f6fe92d4131a 100644
--- a/headless/lib/browser/headless_browser_impl.h
+++ b/headless/lib/browser/headless_browser_impl.h
@@ -11,7 +11,6 @@
#include <unordered_map>
#include <vector>
-#include "base/synchronization/lock.h"
#include "headless/lib/browser/headless_web_contents_impl.h"
namespace aura {
@@ -35,6 +34,8 @@ class HeadlessBrowserImpl : public HeadlessBrowser {
~HeadlessBrowserImpl() override;
// HeadlessBrowser implementation:
+ HeadlessWebContents::Builder CreateWebContentsBuilder() override;
+ HeadlessBrowserContext::Builder CreateBrowserContextBuilder() override;
HeadlessWebContents* CreateWebContents(const GURL& initial_url,
const gfx::Size& size) override;
scoped_refptr<base::SingleThreadTaskRunner> BrowserMainThread()
@@ -49,12 +50,11 @@ class HeadlessBrowserImpl : public HeadlessBrowser {
void set_browser_main_parts(HeadlessBrowserMainParts* browser_main_parts);
HeadlessBrowserMainParts* browser_main_parts() const;
- HeadlessBrowserContext* browser_context() const;
-
void RunOnStartCallback();
HeadlessBrowser::Options* options() { return &options_; }
+ HeadlessWebContents* CreateWebContents(HeadlessWebContents::Builder* builder);
HeadlessWebContentsImpl* RegisterWebContents(
std::unique_ptr<HeadlessWebContentsImpl> web_contents);
« no previous file with comments | « headless/lib/browser/headless_browser_context_impl.cc ('k') | headless/lib/browser/headless_browser_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698