Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2043583002: Remove the use of OwnedPtrDeleter in WebMessagePortChannel. (Closed)

Created:
4 years, 6 months ago by Yuta Kitamura
Modified:
4 years, 6 months ago
Reviewers:
kinuko, haraken, nhiroki, tzik
CC:
chromium-reviews, kinuko+worker_chromium.org, sof, eae+blinkwatch, falken, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, horo+watch_chromium.org, kinuko+watch, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the use of OwnedPtrDeleter in WebMessagePortChannel. It's hard to mechanically replace specializations of OwnedPtrDeleter<T> to std::unique_ptr equivalents, so they are converted manually. A new typedef WebMessagePortChannelUniquePtr is introduced so people can always use std::unique_ptr with a correct deleter. BUG=617504 Committed: https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd Cr-Commit-Position: refs/heads/master@{#398213}

Patch Set 1 #

Messages

Total messages: 26 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043583002/1
4 years, 6 months ago (2016-06-06 05:47:45 UTC) #2
Yuta Kitamura
The core changes are in public/platform/WebMessagePortChannel.h. tzik: PTAL? nhiroki: I would like to have this ...
4 years, 6 months ago (2016-06-06 05:50:49 UTC) #5
tzik
lgtm
4 years, 6 months ago (2016-06-06 05:56:35 UTC) #6
nhiroki
lgtm
4 years, 6 months ago (2016-06-06 06:12:32 UTC) #8
Yuta Kitamura
kinuko: PTAL as an OWNER of public/?
4 years, 6 months ago (2016-06-06 06:19:47 UTC) #10
kinuko
lgtm
4 years, 6 months ago (2016-06-06 06:46:30 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 07:42:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043583002/1
4 years, 6 months ago (2016-06-06 09:16:12 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/195503)
4 years, 6 months ago (2016-06-06 09:22:37 UTC) #17
Yuta Kitamura
Ah, I need web/ approval, too. haraken: PTAL?
4 years, 6 months ago (2016-06-07 02:39:40 UTC) #19
haraken
LGTM
4 years, 6 months ago (2016-06-07 02:40:12 UTC) #20
haraken
LGTM
4 years, 6 months ago (2016-06-07 02:40:13 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043583002/1
4 years, 6 months ago (2016-06-07 03:02:54 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 03:07:30 UTC) #24
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 03:08:54 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd
Cr-Commit-Position: refs/heads/master@{#398213}

Powered by Google App Engine
This is Rietveld 408576698