Zero closed ThreadCondition handles

Zero closed ThreadCondition handles

The ThreadCondition constructor checks for failed calls to CreateMutex
and CreateSemaphore, but if they are detected it closes the handles
without zeroing them. This change zeroes them to avoid unpredictable
behavior from use-after-close.

The change also checks for nullptr before closing them in the destructor
in order to keep handle verifiers happy.

BUG=615306
Committed: https://crrev.com/42b7246433e2b79901292d2bc97dc6607530fac2
Cr-Commit-Position: refs/heads/master@{#398314}

[brucedawson, 2016-06-06 21:43:43]

Description was changed from

==========
Zero closed ThreadCondition handles

The ThreadCondition constructor checks for failed calls to CreateMutex
and CreateSemaphore, but if they are detected it closes the handles
without zeroing them. This change zeroes them to avoid unpredictable
behavior from use-after-close.

The change also checks for nullptr before closing them in the destructor
in order to keep handle verifier's happy.

BUG=615306
==========

to

==========
Zero closed ThreadCondition handles

The ThreadCondition constructor checks for failed calls to CreateMutex
and CreateSemaphore, but if they are detected it closes the handles
without zeroing them. This change zeroes them to avoid unpredictable
behavior from use-after-close.

The change also checks for nullptr before closing them in the destructor
in order to keep handle verifier's happy.

BUG=615306
==========

[brucedawson, 2016-06-06 21:43:44]

brucedawson@chromium.org changed reviewers:
+ esprehn@chromium.org

[brucedawson, 2016-06-06 22:16:36]

Description was changed from

==========
Zero closed ThreadCondition handles

The ThreadCondition constructor checks for failed calls to CreateMutex
and CreateSemaphore, but if they are detected it closes the handles
without zeroing them. This change zeroes them to avoid unpredictable
behavior from use-after-close.

The change also checks for nullptr before closing them in the destructor
in order to keep handle verifier's happy.

BUG=615306
==========

to

==========
Zero closed ThreadCondition handles

The ThreadCondition constructor checks for failed calls to CreateMutex
and CreateSemaphore, but if they are detected it closes the handles
without zeroing them. This change zeroes them to avoid unpredictable
behavior from use-after-close.

The change also checks for nullptr before closing them in the destructor
in order to keep handle verifiers happy.

BUG=615306
==========

[brucedawson, 2016-06-06 23:02:36]

PTAL. This should be a condition that we never hit, but the current state still
makes me nervous/uncertain.

[sof, 2016-06-07 05:14:52]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2016-06-07 05:14:52]

lgtm

[esprehn, 2016-06-07 05:45:33]

lgtm

[brucedawson, 2016-06-07 16:45:26]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-06-07 16:45:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043553003/1

[commit-bot: I haz the power, 2016-06-07 16:49:43]

Description was changed from

==========
Zero closed ThreadCondition handles

The ThreadCondition constructor checks for failed calls to CreateMutex
and CreateSemaphore, but if they are detected it closes the handles
without zeroing them. This change zeroes them to avoid unpredictable
behavior from use-after-close.

The change also checks for nullptr before closing them in the destructor
in order to keep handle verifiers happy.

BUG=615306
==========

to

==========
Zero closed ThreadCondition handles

The ThreadCondition constructor checks for failed calls to CreateMutex
and CreateSemaphore, but if they are detected it closes the handles
without zeroing them. This change zeroes them to avoid unpredictable
behavior from use-after-close.

The change also checks for nullptr before closing them in the destructor
in order to keep handle verifiers happy.

BUG=615306
==========

[commit-bot: I haz the power, 2016-06-07 16:49:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-07 16:51:14]

Description was changed from

==========
Zero closed ThreadCondition handles

The ThreadCondition constructor checks for failed calls to CreateMutex
and CreateSemaphore, but if they are detected it closes the handles
without zeroing them. This change zeroes them to avoid unpredictable
behavior from use-after-close.

The change also checks for nullptr before closing them in the destructor
in order to keep handle verifiers happy.

BUG=615306
==========

to

==========
Zero closed ThreadCondition handles

The ThreadCondition constructor checks for failed calls to CreateMutex
and CreateSemaphore, but if they are detected it closes the handles
without zeroing them. This change zeroes them to avoid unpredictable
behavior from use-after-close.

The change also checks for nullptr before closing them in the destructor
in order to keep handle verifiers happy.

BUG=615306

Committed: https://crrev.com/42b7246433e2b79901292d2bc97dc6607530fac2
Cr-Commit-Position: refs/heads/master@{#398314}
==========

[commit-bot: I haz the power, 2016-06-07 16:51:15]

Patchset 1 (id:??) landed as
https://crrev.com/42b7246433e2b79901292d2bc97dc6607530fac2
Cr-Commit-Position: refs/heads/master@{#398314}