Issue 204353011: If install of test apk fails because of storage, wipe device data.

Issue 204353011: If install of test apk fails because of storage, wipe device data. (Closed)

Created:
6 years, 9 months ago by navabi

Modified:
6 years, 9 months ago

Reviewers:
craigdh, avayvod1, bulach, friedman, Paweł Hajdan Jr., tonyg

CC:
chromium-reviews, klundberg+watch_chromium.org, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

If install of test apk fails because of storage, wipe device data. Also, remove install of apk in device status check to track install speed. We have not been tracking install speed and have not found it to be very useful. I want to avoid doing too many installs. We can bring it back if we find out that it is useful. We originally added it because installs were timing out, but we found install speed to be too variable across the same device to be useful. BUG=335549 TBR=craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258967

Patch Set 1 #

Patch Set 2 : Update description to include removal from status check. #

Total comments: 1

Patch Set 3 : Copy adb_keys after wipe data. #

Patch Set 4 : Use constants.ADB_KEYS_FILE. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -22 lines)			Patch
M	build/android/buildbot/bb_device_status_check.py	View		4 chunks	+4 lines, -22 lines	0 comments	Download
M	build/android/provision_devices.py	View	1 2 3	3 chunks	+36 lines, -0 lines	0 comments	Download
M	build/android/pylib/constants.py	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

navabi

https://codereview.chromium.org/204353011/diff/20001/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/204353011/diff/20001/build/android/provision_devices.py#newcode100 build/android/provision_devices.py:100: if failure_string not in install_output: oops, this was for ...

6 years, 9 months ago (2014-03-21 00:12:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/204353011/60001

6 years, 9 months ago (2014-03-24 16:06:00 UTC) #4

Message was sent while issue was closed.

Change committed as 258967

Expand Messages | Collapse Messages