Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 204353007: [Android] Extract device blacklisting into its own module. (Closed)

Created:
6 years, 9 months ago by jbudorick
Modified:
6 years, 8 months ago
Reviewers:
klundberg, bulach, navabi1
CC:
chromium-reviews, klundberg+watch_chromium.org, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Extract device blacklisting into its own module. BUG=267773 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260645

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address Marcus's comments. #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -23 lines) Patch
M build/android/buildbot/bb_device_status_check.py View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/android_commands.py View 1 2 3 4 3 chunks +15 lines, -20 lines 0 comments Download
A build/android/pylib/device/device_blacklist.py View 1 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jbudorick
extracting the recently added device blacklisting functionality as part of the android_commands refactor/replacement task
6 years, 9 months ago (2014-03-20 17:35:55 UTC) #1
bulach
lgtm once others are happy, thanks! just a few nits and suggestions below: https://codereview.chromium.org/204353007/diff/1/build/android/pylib/device/device_blacklist.py File ...
6 years, 9 months ago (2014-03-21 14:38:55 UTC) #2
klundberg
No expert on these pieces but lgtm :-)
6 years, 9 months ago (2014-03-21 18:03:33 UTC) #3
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 9 months ago (2014-03-25 00:16:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/204353007/60001
6 years, 9 months ago (2014-03-25 00:18:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 00:54:51 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=57160
6 years, 9 months ago (2014-03-25 00:54:52 UTC) #7
jbudorick
Armand, can you do a quick owner's review on this when you get a moment?
6 years, 9 months ago (2014-03-26 16:48:09 UTC) #8
navabi1
On 2014/03/26 16:48:09, jbudorick wrote: > Armand, can you do a quick owner's review on ...
6 years, 8 months ago (2014-03-31 18:35:10 UTC) #9
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 8 months ago (2014-03-31 18:36:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/204353007/90001
6 years, 8 months ago (2014-03-31 18:40:10 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 21:12:40 UTC) #12
Message was sent while issue was closed. 
Change committed as 260645

Powered by Google App Engine
This is Rietveld 408576698