Source/web/tests/WebFrameTest.cpp - Issue 204353005: Remove use of SkBitmap::Config (deprecated) from Source/web/tests/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 204353005: Remove use of SkBitmap::Config (deprecated) from Source/web/tests/. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add EXPECT_TRUE in two places ASSERT_TRUE does not work Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index e25925b6d3a4925840faedaf62b18d0751307941..57cbf5871fda24b19d960e7ff38f3d5956fd8970 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -2058,8 +2058,7 @@ TEST_F(WebFrameTest, pageScaleFactorScalesPaintClip)

webViewHelper.webView()->setPageScaleFactor(0.5, WebPoint());

SkBitmap bitmap;

- bitmap.setConfig(SkBitmap::kARGB_8888_Config, 200, 200);

- bitmap.allocPixels();

+ ASSERT_TRUE(bitmap.allocN32Pixels(200, 200));

bitmap.eraseColor(0);

SkCanvas canvas(bitmap);

« no previous file with comments | « Source/web/tests/ImageLayerChromiumTest.cpp ('k') | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »