Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: test/mjsunit/harmony/symbols.js

Issue 204353004: Revert "Implement ES6 symbol registry and predefined symbols" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/harmony/private.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/harmony/symbols.js
diff --git a/test/mjsunit/harmony/symbols.js b/test/mjsunit/harmony/symbols.js
index d19aece5b17202f6bd1b9e841561f5691c56fc86..26adb74660f3d7a05a8025db47a72eb072f47446 100644
--- a/test/mjsunit/harmony/symbols.js
+++ b/test/mjsunit/harmony/symbols.js
@@ -410,42 +410,15 @@ function TestGetOwnPropertySymbolsWithProto() {
TestGetOwnPropertySymbolsWithProto()
-function TestRegistry() {
- assertFalse(Symbol.for("@@create") === Symbol.create)
- assertFalse(Symbol.for("@@iterator") === Symbol.iterator)
- assertTrue(Symbol.keyFor(Symbol.create) === undefined)
- assertTrue(Symbol.keyFor(Symbol.iterator) === undefined)
-
- var symbol1 = Symbol.for("x1")
- var symbol2 = Symbol.for("x2")
- assertFalse(symbol1 === symbol2)
-
- assertSame(symbol1, Symbol.for("x1"))
- assertSame(symbol2, Symbol.for("x2"))
- assertSame("x1", Symbol.keyFor(symbol1))
- assertSame("x2", Symbol.keyFor(symbol2))
-
- assertSame(Symbol.for("1"), Symbol.for(1))
- assertThrows(function() { Symbol.keyFor("bla") }, TypeError)
- assertThrows(function() { Symbol.keyFor({}) }, TypeError)
-
- var realm = Realm.create()
- assertFalse(Symbol === Realm.eval(realm, "Symbol"))
- assertFalse(Symbol.for === Realm.eval(realm, "Symbol.for"))
- assertFalse(Symbol.keyFor === Realm.eval(realm, "Symbol.keyFor"))
- assertSame(Symbol.create, Realm.eval(realm, "Symbol.create"))
- assertSame(Symbol.iterator, Realm.eval(realm, "Symbol.iterator"))
-
- assertSame(symbol1, Realm.eval(realm, "Symbol.for")("x1"))
- assertSame(symbol1, Realm.eval(realm, "Symbol.for('x1')"))
- assertSame("x1", Realm.eval(realm, "Symbol.keyFor")(symbol1))
- Realm.shared = symbol1
- assertSame("x1", Realm.eval(realm, "Symbol.keyFor(Realm.shared)"))
-
- var symbol3 = Realm.eval(realm, "Symbol.for('x3')")
- assertFalse(symbol1 === symbol3)
- assertFalse(symbol2 === symbol3)
- assertSame(symbol3, Symbol.for("x3"))
- assertSame("x3", Symbol.keyFor(symbol3))
+function TestGetOwnPropertySymbolsWithPrivateSymbols() {
+ var privateSymbol = %CreatePrivateSymbol("private")
+ var publicSymbol = Symbol()
+ var publicSymbol2 = Symbol()
+ var obj = {}
+ obj[publicSymbol] = 1
+ obj[privateSymbol] = 2
+ obj[publicSymbol2] = 3
+ var syms = Object.getOwnPropertySymbols(obj)
+ assertEquals(syms, [publicSymbol, publicSymbol2])
}
-TestRegistry()
+TestGetOwnPropertySymbolsWithPrivateSymbols()
« no previous file with comments | « test/mjsunit/harmony/private.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698