third_party/WebKit/Source/core/html/HTMLDialogElement.idl - Issue 2043503002: Add [CEReactions] IDL attributes for Custom Elements V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLDialogElement.idl

Issue 2043503002: Add [CEReactions] IDL attributes for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: yukishiino review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/methods.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLDetailsElement.idl ('k') | third_party/WebKit/Source/core/html/HTMLDirectoryElement.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLDialogElement.idl

diff --git a/third_party/WebKit/Source/core/html/HTMLDialogElement.idl b/third_party/WebKit/Source/core/html/HTMLDialogElement.idl

index b6d871128754bcfc19a0243030ed6b58c73e951a..e6704616f29c3164b46f5a32d31e02d4969993a7 100644

--- a/third_party/WebKit/Source/core/html/HTMLDialogElement.idl

+++ b/third_party/WebKit/Source/core/html/HTMLDialogElement.idl

@@ -26,11 +26,11 @@

// https://html.spec.whatwg.org/#the-dialog-element

interface HTMLDialogElement : HTMLElement {

- [Reflect] attribute boolean open;

+ [CEReactions, Reflect] attribute boolean open;

attribute DOMString returnValue;

// FIXME: show() and showModal() should take an anchor argument.

- void show();

- [RaisesException] void showModal();

+ [CEReactions] void show();

+ [CEReactions, RaisesException] void showModal();

// FIXME: The returnValue argument should have no default value.

- [RaisesException] void close(optional DOMString returnValue = null);

+ [CEReactions, RaisesException] void close(optional DOMString returnValue = null);

};