third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp - Issue 2043503002: Add [CEReactions] IDL attributes for Custom Elements V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp

Issue 2043503002: Add [CEReactions] IDL attributes for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: yukishiino review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/methods.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElement.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp

index 031cf43724dfcc92528917cf05a45a356ba8ede6..3b3898bf5432cc9bee122b25a9c88dde9abdb555 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp

@@ -90,8 +90,6 @@ void CustomElementsRegistry::define(

const ElementRegistrationOptions& options,

ExceptionState& exceptionState)

{

- CEReactionsScope reactions;

if (!builder.checkConstructorIntrinsics())

return;

@@ -149,11 +147,8 @@ void CustomElementsRegistry::define(

HeapVector<Member<Element>> candidates;

collectCandidates(descriptor, &candidates);

- for (Element* candidate : candidates) {

- reactions.enqueue(

- candidate,

- new CustomElementUpgradeReaction(definition));

- }

+ for (Element* candidate : candidates)

+ CustomElement::enqueueUpgradeReaction(candidate, definition);

// TODO(dominicc): Implement steps:

// 20: when-defined promise processing