third_party/WebKit/Source/bindings/templates/interface.cpp - Issue 2043503002: Add [CEReactions] IDL attributes for Custom Elements V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.cpp

Issue 2043503002: Add [CEReactions] IDL attributes for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: yukishiino review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/attributes.cpp ('K') | « third_party/WebKit/Source/bindings/templates/attributes.cpp ('k') | third_party/WebKit/Source/bindings/templates/methods.cpp » ('j') | third_party/WebKit/Source/bindings/templates/methods.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/interface.cpp b/third_party/WebKit/Source/bindings/templates/interface.cpp

index 4350d082736ca0b7f88a4af6256350b3268a07a9..c6962901e257cbfa1db22a044db7806bbe20b2e1 100644

--- a/third_party/WebKit/Source/bindings/templates/interface.cpp

+++ b/third_party/WebKit/Source/bindings/templates/interface.cpp

@@ -150,6 +150,9 @@ static void indexedPropertyDeleter(uint32_t index, const v8::PropertyCallbackInf

{% set deleter = indexed_property_deleter %}

static void indexedPropertyDeleterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Boolean>& info)

{

+ {% if deleter.is_ce_reactions %}

+ CEReactionsScope ceReactionsScope;

+ {% endif %}

{% if deleter.is_custom %}

{{v8_class}}::indexedPropertyDeleterCustom(index, info);

{% else %}

@@ -379,6 +382,9 @@ static void namedPropertyDeleterCallback(v8::Local<v8::Name> name, const v8::Pro

{

if (!name->IsString())

return;

+ {% if deleter.is_ce_reactions %}

+ CEReactionsScope ceReactionsScope;

+ {% endif %}

{% if deleter.is_custom %}

{{v8_class}}::namedPropertyDeleterCustom(name, info);

{% else %}