Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2043473002: Convert media-ended*, media-extension* and media-load* tests to testharness.js (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-apps-reviews_chromium.org, chromium-reviews, eric.carlson_apple.com, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert media-ended*, media-extension* and media-load* tests to testharness.js Cleaning up media-ended*, media-extension* and media-load* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/37f87e070d457484ad168a591dc1c74125a087a1 Cr-Commit-Position: refs/heads/master@{#397943}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -195 lines) Patch
M third_party/WebKit/LayoutTests/media/media-ended.html View 1 chunk +41 lines, -63 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-ended-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-extension-with-fragment.html View 1 chunk +13 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-extension-with-fragment-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-load-event.html View 1 chunk +26 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-load-event-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-04 11:57:30 UTC) #4
fs
lgtm
4 years, 6 months ago (2016-06-04 18:02:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043473002/20001
4 years, 6 months ago (2016-06-05 02:48:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-05 20:06:12 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-05 20:07:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37f87e070d457484ad168a591dc1c74125a087a1
Cr-Commit-Position: refs/heads/master@{#397943}

Powered by Google App Engine
This is Rietveld 408576698