Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2043453002: [DevTools] Remove obsolete methods from V8InjectedScriptHost (Closed)

Created:
4 years, 6 months ago by kozy
Modified:
4 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove obsolete methods from V8InjectedScriptHost BUG=595206 R=dgozman@chromium.org Committed: https://crrev.com/9ebca28dcc83ac6d5599a494f729f6ac5bfdddb2 Cr-Commit-Position: refs/heads/master@{#397895}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js View 1 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kozy
Dmitry, please take a look!
4 years, 6 months ago (2016-06-04 01:31:36 UTC) #1
dgozman
lgtm
4 years, 6 months ago (2016-06-04 02:00:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043453002/40001
4 years, 6 months ago (2016-06-04 02:27:26 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-04 02:59:21 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 03:00:25 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9ebca28dcc83ac6d5599a494f729f6ac5bfdddb2
Cr-Commit-Position: refs/heads/master@{#397895}

Powered by Google App Engine
This is Rietveld 408576698