Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 204343006: Provide default traits for PersistentValueMap (Closed)

Created:
6 years, 9 months ago by vogelheim
Modified:
6 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Provide default traits for PersistentValueMap Re-try of issue 201643003. This caused linker errors on Win64, since the linker insists on seeing the StrongMapTrait method implementations even though they are never used. This will provide default implementations for them. R=dcarney@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20084

Patch Set 1 : Original patch from 201643003. #

Patch Set 2 : Provide default implementations for StrongMapTraits methods, plus some minor style fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -77 lines) Patch
M include/v8-util.h View 1 8 chunks +171 lines, -35 lines 0 comments Download
M test/cctest/test-api.cc View 4 chunks +15 lines, -42 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vogelheim
Re-trying https://codereview.chromium.org/201643003 So... I tried several variants to fix this, but without any real success. ...
6 years, 9 months ago (2014-03-19 15:18:29 UTC) #1
dcarney
lgtm
6 years, 9 months ago (2014-03-19 15:23:13 UTC) #2
dcarney
6 years, 9 months ago (2014-03-19 15:35:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20084 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698