Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 204343005: MIPS: Reland "Add out-of-line constant pool support to Arm." (Closed)

Created:
6 years, 9 months ago by kilvadyb
Modified:
6 years, 9 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Reland "Add out-of-line constant pool support to Arm." Port r20053 (df27abf) Original commit message: This CL adds out-of-line constant pool support to Arm. A ConstantPoolBuilder object is introduced to manage building of the ConstantPoolArray for a given code object. This CL depends on the following CLs landing first: https://codereview.chromium.org/138503002/ https://codereview.chromium.org/179813005/ https://codereview.chromium.org/183553003/ https://codereview.chromium.org/183803022/ https://codereview.chromium.org/183883011/ https://codereview.chromium.org/186733006/ https://codereview.chromium.org/188063002/ https://codereview.chromium.org/190793002/ https://codereview.chromium.org/190823002/ https://codereview.chromium.org/190833002/ https://codereview.chromium.org/190883002/ BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/mips/assembler-mips.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
6 years, 9 months ago (2014-03-19 12:13:17 UTC) #1
Paul Lind
lgtm
6 years, 9 months ago (2014-03-19 15:31:33 UTC) #2
Paul Lind
6 years, 9 months ago (2014-03-19 15:35:44 UTC) #3
Committed as r20083.

Powered by Google App Engine
This is Rietveld 408576698