components/autofill/content/renderer/password_autofill_agent.cc - Issue 204343004: Add supports that allow Autofill to be initiated from textarea field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 204343004: Add supports that allow Autofill to be initiated from textarea field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Correct the returned value expectations for OnSuggestionReturned() Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/page_click_tracker.cc ('k') | components/autofill/core/browser/autocomplete_history_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.cc

diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc

index df8056242e3eed16495550ae170eeafec6200860..cf74e810e9fef5818ce38ebed8a001fc8512732a 100644

--- a/components/autofill/content/renderer/password_autofill_agent.cc

+++ b/components/autofill/content/renderer/password_autofill_agent.cc

@@ -637,7 +637,7 @@ void PasswordAutofillAgent::OnFillPasswordForm(

FormData form;

FormFieldData field;

- FindFormAndFieldForInputElement(

+ FindFormAndFieldForFormControlElement(

username_element, &form, &field, REQUIRE_NONE);

Send(new AutofillHostMsg_AddPasswordFormMapping(

routing_id(),

@@ -699,7 +699,7 @@ bool PasswordAutofillAgent::ShowSuggestionPopup(

FormData form;

FormFieldData field;

- FindFormAndFieldForInputElement(

+ FindFormAndFieldForFormControlElement(

user_input, &form, &field, REQUIRE_NONE);

blink::WebInputElement selected_element = user_input;