components/autofill/content/renderer/form_cache.cc - Issue 204343004: Add supports that allow Autofill to be initiated from textarea field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/form_cache.cc

Issue 204343004: Add supports that allow Autofill to be initiated from textarea field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Correct the returned value expectations for OnSuggestionReturned() Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/form_cache.h ('k') | components/autofill/content/renderer/page_click_listener.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/form_cache.cc

diff --git a/components/autofill/content/renderer/form_cache.cc b/components/autofill/content/renderer/form_cache.cc

index 431979ebd4c8a6875473e974780ec7bdee3e7ce0..d9acf3755296bea33d9b8c2b8b90745c0bf3f146 100644

--- a/components/autofill/content/renderer/form_cache.cc

+++ b/components/autofill/content/renderer/form_cache.cc

@@ -179,7 +179,7 @@ void FormCache::ResetFrame(const WebFrame& frame) {

RemoveOldElements(frame, &initial_checked_state_);

}

-bool FormCache::ClearFormWithElement(const WebInputElement& element) {

+bool FormCache::ClearFormWithElement(const WebFormControlElement& element) {

WebFormElement form_element = element.form();

if (form_element.isNull())

return false;

« no previous file with comments | « components/autofill/content/renderer/form_cache.h ('k') | components/autofill/content/renderer/page_click_listener.h » ('j') | no next file with comments »