components/autofill/core/browser/autofill_manager.cc - Issue 204343004: Add supports that allow Autofill to be initiated from textarea field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 204343004: Add supports that allow Autofill to be initiated from textarea field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update code as per Ilya's review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autocomplete_history_manager_unittest.cc ('K') | « components/autofill/core/browser/autocomplete_history_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 96f7eb27df315de12b8a11fa014a0ec83fa46e98..80902aa7dd8ee6ab53e60a19fb08e7112eda66a9 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -450,7 +450,8 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,

// hand off what we generated and they will send the results back to the

// renderer.

autocomplete_history_manager_->OnGetAutocompleteSuggestions(

- query_id, field.name, field.value, values, labels, icons, unique_ids);

+ query_id, field.name, field.value, field.form_control_type, values,

+ labels, icons, unique_ids);

}

void AutofillManager::FillOrPreviewForm(