Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: components/autofill/core/browser/autofill_manager.cc

Issue 204343004: Add supports that allow Autofill to be initiated from textarea field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Correct the returned value expectations for OnSuggestionReturned() Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/autofill/core/browser/autocomplete_history_manager_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/autofill_manager.h" 5 #include "components/autofill/core/browser/autofill_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <limits> 9 #include <limits>
10 #include <map> 10 #include <map>
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 has_logged_address_suggestions_count_ = true; 443 has_logged_address_suggestions_count_ = true;
444 } 444 }
445 } 445 }
446 } 446 }
447 } 447 }
448 448
449 // Add the results from AutoComplete. They come back asynchronously, so we 449 // Add the results from AutoComplete. They come back asynchronously, so we
450 // hand off what we generated and they will send the results back to the 450 // hand off what we generated and they will send the results back to the
451 // renderer. 451 // renderer.
452 autocomplete_history_manager_->OnGetAutocompleteSuggestions( 452 autocomplete_history_manager_->OnGetAutocompleteSuggestions(
453 query_id, field.name, field.value, values, labels, icons, unique_ids); 453 query_id, field.name, field.value, field.form_control_type, values,
454 labels, icons, unique_ids);
454 } 455 }
455 456
456 void AutofillManager::FillOrPreviewForm( 457 void AutofillManager::FillOrPreviewForm(
457 AutofillDriver::RendererFormDataAction action, 458 AutofillDriver::RendererFormDataAction action,
458 int query_id, 459 int query_id,
459 const FormData& form, 460 const FormData& form,
460 const FormFieldData& field, 461 const FormFieldData& field,
461 int unique_id) { 462 int unique_id) {
462 if (!IsValidFormData(form) || !IsValidFormFieldData(field)) 463 if (!IsValidFormData(form) || !IsValidFormFieldData(field))
463 return; 464 return;
(...skipping 694 matching lines...) Expand 10 before | Expand all | Expand 10 after
1158 return false; 1159 return false;
1159 1160
1160 // Disregard forms that we wouldn't ever autofill in the first place. 1161 // Disregard forms that we wouldn't ever autofill in the first place.
1161 if (!form.ShouldBeParsed(true)) 1162 if (!form.ShouldBeParsed(true))
1162 return false; 1163 return false;
1163 1164
1164 return true; 1165 return true;
1165 } 1166 }
1166 1167
1167 } // namespace autofill 1168 } // namespace autofill
OLDNEW
« no previous file with comments | « components/autofill/core/browser/autocomplete_history_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698