Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: tests/standalone/io/socket_invalid_arguments_test.dart

Issue 204343003: Close(destroy) Socket on user-generated write error. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/socket_patch.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/socket_invalid_arguments_test.dart
diff --git a/tests/standalone/io/socket_invalid_arguments_test.dart b/tests/standalone/io/socket_invalid_arguments_test.dart
index e928cafd483495591e9d2faee37f8394935d5e6c..803e106714d09e12a4ac001508ae239d5752f7d0 100644
--- a/tests/standalone/io/socket_invalid_arguments_test.dart
+++ b/tests/standalone/io/socket_invalid_arguments_test.dart
@@ -30,20 +30,24 @@ testSocketCreation(host, port) {
testAdd(buffer) {
asyncStart();
+ asyncStart();
ServerSocket.bind("127.0.0.1", 0).then((server) {
server.listen((socket) => socket.destroy());
Socket.connect("127.0.0.1", server.port).then((socket) {
int errors = 0;
- socket.done.catchError((e) { errors++; });
+ socket.done
+ .catchError((e) { errors++; })
+ .then((_) {
+ Expect.equals(1, errors);
+ asyncEnd();
+ server.close();
+ });
socket.listen(
(_) { },
onError: (error) {
Expect.fail("Error on stream");
},
onDone: () {
- Expect.equals(1, errors);
- socket.destroy();
- server.close();
asyncEnd();
});
socket.add(buffer);
« no previous file with comments | « runtime/bin/socket_patch.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698